fix(author): fail on create due to functions as enumerable properties overridden in Object.assign #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 Edited: 2024-05-17 12:24:35 UTC |
mlbrgl
force-pushed
the
fix-author-creation-bake
branch
from
3691a52
to
739e1c4
Compare
ikesau
approved these changes
May 16, 2024
There was a problem hiding this comment.
Can confirm this allows author pages to be published and baked. Other page types (topic pages/homepage) get baked correctly, too.
Also made a gist to confirm the explanation in the comments: https://gist.github.com/ikesau/9271c5574f787a8e7457e3956cda6e04
db/model/Gdoc/GdocFactory.ts
Outdated
| // enrichments are not present on the Gdoc subclass when loading from the DB | ||
| // (GdocsContentSource.Internal), since subclass enrichements are only done | ||
| // while fetching the live gdocs (GdocsContentSource.Gdocs) in | ||
| // loadFromGdocBase(). |
|
For reference, here is the presentation given on this topic yesterday during tech tea: Where.do.carrots.grow.mp4 |
mlbrgl
force-pushed
the
fix-author-creation-bake
branch
from
68188ac
to
e22c44c
Compare
mlbrgl
force-pushed
the
fix-author-creation-bake
branch
from
e22c44c
to
c34498e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate solution to #3578, which had to be reverted because this.content in GdocPost would be honored by _.defaults as a property not to override, but would result in the
contentproperty not respectingOwidGdocContentat run time.What changed?
This PR promotes GdocBase instance-level functions (e.g.
_enrichSubclassContentas class methods.Why make this change?
GdocAuthor (but also GdocPost, GdocHomepage and Gdoc DataInsight) are created from a GdocBase instance (only when inserting a new Gdoc) using
Object.assign(gdocAuthor, gdocBase). This call lists all enumerable properties on GdocBase, including instance-level functions such as_enrichSubclassContent, and overrides the subclass version.This leads to the subclass enrichment not being performed, and in the case of author creation, an error.
Follow-up
Promoting instance-level functions to class methods on
GdocBaseis enough to solve this issue, but we should consider whether to apply the same treatment to the GdocBase subclasses too.