Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(baker): allow bake dirs for all gdoc types #3310

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Mar 6, 2024

This is in preparation of baking author pages under /team.

This PR reuses the getCanonicalUrl logic to build a bake path for all gdocs.

This was referenced Mar 6, 2024
@mlbrgl mlbrgl requested a review from marcelgerber March 6, 2024 17:54
@mlbrgl mlbrgl marked this pull request as ready for review March 6, 2024 17:54
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way of building on #3280, go for it! 🙌🏻

@mlbrgl mlbrgl mentioned this pull request Mar 8, 2024
24 tasks
@mlbrgl mlbrgl merged commit 62fb2cb into fix-first-rw Mar 8, 2024
13 of 16 checks passed
@mlbrgl mlbrgl deleted the generic-bake-dir branch March 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants