Add author header #3256
Merged
Add author header #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlbrgl
commented
Feb 28, 2024
Comment on lines
+28
to
+56
| _enrichSubclassContent = (content: Record<string, any>): void => { | ||
| if (content.bio) { | ||
| content.bio = content.bio.map((html: RawBlockText) => | ||
| htmlToEnrichedTextBlock(html.value) | ||
| ) | ||
| } | ||
| if (content.socials) { | ||
| // We're parsing here an ArchieML array of objects outside of the | ||
| // usual freeform array [+body]. This means we need to manually | ||
| // reconstruct the {type, value} object created by freeform arrays | ||
| // that parseSocials expects. Technically, we could just parse the | ||
| // [socials] array without all the parseRawBlocksToEnrichedBlocks | ||
| // machinery (like we dit above for the [bio] block), but this way | ||
| // we benefit from features and the predictability of the regular | ||
| // parsing pipeline. In particular, this gives us round trip testing | ||
| // and the documenting of blocks in a consistent way, wihch is more | ||
| // justifiable here compared to the bio block given the wider array | ||
| // of edge cases for this block. | ||
| content.socials = parseSocials({ | ||
| type: "socials", | ||
| value: content.socials, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
@ikesau I'm curious if you have any thoughts on the handling of the bio and socials section of the header:
- bio: just a property with possibly rich text
- socials: a full-blown Archie block outside of the [+body]
This was referenced Mar 2, 2024
mlbrgl
force-pushed
the
fix-style-research-writing
branch
from
09336c6
to
751e8db
Compare
mlbrgl
force-pushed
the
author-header
branch
3 times, most recently
from
cd886f2
to
557eda7
Compare
|
@danyx23 I'm sending you this for review ahead of responsive styles to parallelize structural discussions with the less problematic, more straightforward mobile styles, for which a design review is usually enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new "Author" OwidGdocType and associated template.
👉 See this comment for some of the more structural decisions I made.
staging preview, gdoc
Only consider the "🌑 Dark launch" scope from the tracking issue