Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new RPC methods #183

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Add new RPC methods #183

merged 7 commits into from
Aug 31, 2024

Conversation

Hacksore
Copy link
Member

@Hacksore Hacksore commented Jul 28, 2024

No idea how to use this yet 😂

2024-07-28_17-00-50.mp4

New Commands

  • PLAY_SOUNDBOARD_SOUND - Play a soundboard sound from a guild or the global ones
  • GET_SOUNDBOARD_SOUNDS - Requests discord to send you all the guild soundboard sounds

New Events

  • NOTIFICATION_CREATE - sent when the you get a message that tags your or a dm
  • VIDEO_STATE_UPDATE - not working or sure if it's real
  • SCREENSHARE_STATE_UPDATE - not working or sure if it's real

Added oauth scope

In order to use the soundboard and sub to notifications you need to expand the oauth scopes to:

"guilds",
"rpc.notifications.read",

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlayed ❌ Failed (Inspect) Aug 31, 2024 5:31pm

@Kako38
Copy link

Kako38 commented Aug 20, 2024

Thank you for this PR, it has been really helpful. How did you figure out that the name of the command for the soundboard was PLAY_SOUNDBOARD_SOUND?

Just in case someone has trouble with permissions for PLAY_SOUNDBOARD_SOUND, the scope needed should be 'rpc.voice.write'. The Discord doc doesn't mention soundboard for this scope, but the message on the OAuth popup clearly says it gives access to the soundboard.

@Hacksore
Copy link
Member Author

Hey @Kako38

I had found @spdermn02 fork for discord-rpc (spdermn02/RPC@23fe6fd) which he found out the new actions from the stream deck discord plugin.

Seems like they were added specifically for the stream deck 😂.

@Hacksore Hacksore marked this pull request as ready for review August 31, 2024 17:27
@Hacksore Hacksore enabled auto-merge (squash) August 31, 2024 17:27
@Hacksore
Copy link
Member Author

Going to let this land on main but disabled. Once we get to a point where we can find a good use-case for a soundboard we can add this.

The quick napkin sketch is probably like the ping menu from league of legends.

The vibe:
image

actual ping menu in lol:
image

@Hacksore Hacksore merged commit aa5fd40 into main Aug 31, 2024
7 of 8 checks passed
@Hacksore Hacksore deleted the feat/new-rpc-methods branch August 31, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants