Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Voice Channel Effect Send event #6025

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Mar 28, 2023

This PR documents the VOICE_CHANNEL_EFFECT_SEND event, which is sent when a user sends a voice channel effect in a vc that the bot is connected to. Voice channel effects are used for emoji reactions, Soundboard, and Shared Canvas. As only emoji reactions are fully released, I only documented fields relevant for those here. This event is part of the GUILD_VOICE_STATES (1 << 7) intent.

Core fields: channel_id, guild_id, user_id
Emoji reaction and soundboard fields: emoji, animation_type, animation_id
Soundboard fields: sound_id, sound_volume, sound_override_path
Shared Canvas fields: points, streamer_id, line_id, emoji_hose (these are not included in this PR)

Additional notes:

  • animation_ids just map to Lottie files, there appear to be no names so I just documented it as an arbitrary integer instead of an enum
  • Bots cannot send vc effects

@advaith1
Copy link
Contributor Author

since soundboard has been released, I've added the soundboard effect fields to this PR. The shared canvas fields are still omitted

soundboard sound details and management will be in another pr

| emoji? | ?[emoji](#DOCS_RESOURCES_EMOJI/emoji-object) object | The emoji sent, for emoji reaction and soundboard effects |
| animation_type? | integer | The [type of emoji animation](#DOCS_TOPICS_GATEWAY_EVENTS/voice-channel-effect-send-animation-types), for emoji reaction and soundboard effects |
| animation_id? | integer | The ID of the emoji animation, for emoji reaction and soundboard effects |
| sound_id? | snowflake | The ID of the soundboard sound, for soundboard effects |
Copy link
Contributor

@Puncher1 Puncher1 Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sound_id does not necessarily have to be a snowflake. It's an integer when it's a default sound.

Copy link
Contributor Author

@advaith1 advaith1 May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like for default sounds the id is in a string (e.g. "1") in the API but a number in this gw event 🫠

updated to "snowflake or integer"

Copy link
Contributor

@sebm253 sebm253 Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like for default sounds the id is in a string (e.g. "1") in the API but a number in this gw event 🫠

updated to "snowflake or integer"

@advaith1 has this been fixed/changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is staying as-is for now. you should treat 1 and "1" as identical in payloads of this event - do not make assumptions based on whether it is a string or not.

@Talcon2
Copy link

Talcon2 commented Dec 3, 2023

What's the status here, will this become usable?

@bsian03 bsian03 mentioned this pull request Jan 17, 2024
54 tasks
@colinloretz colinloretz self-assigned this May 13, 2024
@colinloretz colinloretz self-requested a review May 14, 2024 20:45
@DV8FromTheWorld
Copy link
Member

When we go to add this to the documentation we should first put them behind a different intent. This should not be bound to voice states intent

@Hacksore
Copy link

Guessing there are no plans to add VOICE_CHANNEL_EFFECT_SEND to the RPC API right?

Copy link
Contributor

@colinloretz colinloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinal-tap-volume

@valdotle
Copy link
Contributor

When we go to add this to the documentation we should first put them behind a different intent. This should not be bound to voice states intent

Have there been any changes in that regard yet?

@advaith1
Copy link
Contributor Author

@valdotle we have decided to keep it in the voice states intent

@advaith1 advaith1 merged commit 952f79a into discord:main Aug 15, 2024
4 checks passed
@Hacksore
Copy link

Guessing there are no plans to add VOICE_CHANNEL_EFFECT_SEND to the RPC API right?

If anyone else is wondering about this see this PR for sending sounds via RPC.
overlayeddev/overlayed#183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants