Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5250 : Add support for logging device DPI events #5270

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Fix #5250 : Add support for logging device DPI events #5270

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc67a8c
ADD: device screen density logging
Dec 12, 2023
5697c57
Merge branch 'oppia:develop' into add-device-dpi
Tejas-67 Dec 12, 2023
2e22b6a
Merge branch 'oppia:develop' into add-device-dpi
Tejas-67 Dec 20, 2023
e98d0c0
updated expected size of bundles in KenyaAlphaEventBundleCreatorTest.kt
Dec 20, 2023
57b3ccd
fixed failing tests in EventBundleCreatorTest.kt
Dec 20, 2023
f14f5cf
Merge branch 'oppia:develop' into add-device-dpi
Tejas-67 Jan 23, 2024
eccc8f0
changed densityDpi value to Configuration().densityDpi
Jan 23, 2024
af5c567
Merge branch 'develop' into add-device-dpi
adhiamboperes Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ class EventBundleCreator @Inject constructor(
private val appVersionCode by lazy { context.getVersionCode() }
private val appVersionName by lazy { context.getVersionName() }
private val eventCount by lazy { AtomicInteger() }
private val screenDensity by lazy {
context.resources.displayMetrics.densityDpi
}
adhiamboperes marked this conversation as resolved.
Show resolved Hide resolved

/**
* Fills the specified [bundle] with a logging-ready representation of [eventLog] and returns a
Expand All @@ -150,6 +153,9 @@ class EventBundleCreator @Inject constructor(
bundle.putString(
"oppia_audio_lang", eventLog.audioTranslationLanguageSelection.toAnalyticsText()
)
bundle.putInt(
"screen_density", screenDensity
)
return eventLog.context.convertToActivityContext().also { eventContext ->
// Only allow user IDs to be logged when the learner study feature is enabled.
eventContext.storeValue(
Expand Down
Loading
Loading