-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5250 : Add support for logging device DPI events #5270
Conversation
@adhiamboperes the tests are failing because of the increase in bundle size by 1 due to addition of screen density value. |
@adhiamboperes please check |
Hi @Tejas-67, I took a look -- yes, modifying the expected size in tests should be the correct way to address this. |
@adhiamboperes please check |
Hi @Tejas-67, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tejas-67!
I have left an improvement suggestion but the overall approach is in the right direction. PTAL.
utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt
Outdated
Show resolved
Hide resolved
Hi @Tejas-67, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@Tejas-67, any update on this? Please assign this PR to me once it ios ready for a final review. |
hey @adhiamboperes, i have done the necessary changes. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tejas-67. This LGTM.
Assigning @BenHenning for code owner reviews. Thanks! |
Explanation
Fix #5250 In the EventBundleCreator class, introduced a new item in the bundle to log the screen density of the device. Stored using the key "screen_density" and value retrieved from resources.displayMetrics.screenDensity .
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: