Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation updates from https://translatewiki.net. #5258

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

translatewiki
Copy link
Member

Translation updates

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR marks FAQ related strings as fuzzy since we renamed some of them in #5247

@adhiamboperes
Copy link
Collaborator

@seanlip, @BenHenning, should I go ahead and merge this PR?

@oppiabot oppiabot bot added the PR: LGTM label Dec 4, 2023
Copy link

oppiabot bot commented Dec 4, 2023

Hi @translatewiki, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes I think you can go ahead and delete the "fuzzy" mark either here or on translatewiki, but either way it should be fine to merge IMO (though for safety maybe just test the UI in Arabic to confirm that it works, i.e. the FUZZY thing doesn't hinder any rendering). Thanks!

@adhiamboperes
Copy link
Collaborator

@adhiamboperes I think you can go ahead and delete the "fuzzy" mark either here or on translatewiki, but either way it should be fine to merge IMO (though for safety maybe just test the UI in Arabic to confirm that it works, i.e. the FUZZY thing doesn't hinder any rendering). Thanks!

The easiest approach will be to do a follow up PR to de-fuzzy the strings, since this branch is protected.

@seanlip seanlip enabled auto-merge (squash) December 11, 2023 11:11
@seanlip seanlip merged commit 106ae65 into develop Dec 11, 2023
36 checks passed
adhiamboperes pushed a commit that referenced this pull request Dec 11, 2023
)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fix PR #5258
This PR removes all fuzzy="true" attributes that were introduced in PR
[#5258](#5258)

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [ ] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

---------

Co-authored-by: translatewiki.net <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants