Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed all fuzzy="true" attributes that were introduced in #5258 #5268

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Removed all fuzzy="true" attributes that were introduced in #5258 #5268

merged 3 commits into from
Dec 11, 2023

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Dec 11, 2023

Explanation

Fix PR #5258
This PR removes all fuzzy="true" attributes that were introduced in PR #5258

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@Rd4dev Rd4dev requested a review from a team as a code owner December 11, 2023 10:22
@Rd4dev Rd4dev requested review from adhiamboperes and removed request for a team December 11, 2023 10:22
@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Dec 11, 2023

@adhiamboperes PTAL

@adhiamboperes adhiamboperes changed the base branch from translatewiki-prs to develop December 11, 2023 11:56
@adhiamboperes
Copy link
Collaborator

Hi @Rd4dev, this branch has some conflicts with develop. Could you please resolve them?

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Dec 11, 2023

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned Rd4dev Dec 11, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 11, 2023

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Dec 11, 2023

Hi @Rd4dev, this branch has some conflicts with develop. Could you please resolve them?

The conflicts in this branch arose from merging the #5258 branch, which had fuzzy="true" attributes. I've addressed these conflicts and pushed the code again. I hope this resolves the issue.

adhiamboperes
adhiamboperes approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rd4dev! Changes LGTM.

@adhiamboperes adhiamboperes merged commit b86a47b into oppia:develop Dec 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@adhiamboperes adhiamboperes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rd4dev @adhiamboperes @translatewiki