Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag #5239

Merged
merged 25 commits into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
002e5b6
Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 21, 2023
f9deac0
Merge branch 'oppia:develop' into EnableLanguageSelectionUi
kmanikanta335 Nov 24, 2023
30bcb91
Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 24, 2023
4b16efe
Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 25, 2023
92fbc8d
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 27, 2023
827d927
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Nov 28, 2023
408e594
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 28, 2023
55348c2
Merge branch 'EnableLanguageSelectionUi' of https://github.com/kmanik…
kmanikanta335 Nov 28, 2023
b4fbfcf
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 29, 2023
4eeb44b
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Nov 29, 2023
232bfed
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Nov 29, 2023
d1ef0c6
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 1, 2023
359b7ca
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Dec 4, 2023
6f01b59
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Dec 5, 2023
a73c33a
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 5, 2023
e4e6f27
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 6, 2023
e8118a0
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 7, 2023
c8d9b20
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 8, 2023
00616d5
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Dec 10, 2023
9c4dc1c
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 11, 2023
9a86546
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag
kmanikanta335 Dec 11, 2023
c93e7a4
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 12, 2023
81eb58e
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 19, 2023
ed0221d
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Dec 26, 2023
ae518b6
Merge branch 'develop' into EnableLanguageSelectionUi
kmanikanta335 Jan 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProvider
import org.oppia.android.util.data.DataProviders.Companion.combineWith
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.PlatformParameterValue
import javax.inject.Inject

/** [ViewModel] for [OptionsFragment]. */
Expand All @@ -32,7 +30,6 @@ class OptionControlsViewModel @Inject constructor(
activity: AppCompatActivity,
private val profileManagementController: ProfileManagementController,
private val oppiaLogger: OppiaLogger,
@EnableLanguageSelectionUi private val enableLanguageSelectionUi: PlatformParameterValue<Boolean>,
private val resourceHandler: AppLanguageResourceHandler,
private val translationController: TranslationController
) : OptionsItemViewModel() {
Expand Down Expand Up @@ -112,13 +109,12 @@ class OptionControlsViewModel @Inject constructor(
}

private fun createAppLanguageViewModel(language: OppiaLanguage): OptionsAppLanguageViewModel? {
return if (enableLanguageSelectionUi.value) {
OptionsAppLanguageViewModel(
routeToAppLanguageListListener,
loadAppLanguageListListener, language,
resourceHandler.computeLocalizedDisplayName(language)
)
} else null
return OptionsAppLanguageViewModel(
routeToAppLanguageListListener,
loadAppLanguageListListener,
language,
resourceHandler.computeLocalizedDisplayName(language)
)
}

private fun createAudioLanguageViewModel(profile: Profile): OptionsAudioLanguageViewModel {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ import androidx.test.espresso.assertion.ViewAssertions.matches
import androidx.test.espresso.intent.Intents
import androidx.test.espresso.intent.Intents.intended
import androidx.test.espresso.intent.matcher.IntentMatchers.hasComponent
import androidx.test.espresso.intent.matcher.IntentMatchers.hasExtra
import androidx.test.espresso.matcher.ViewMatchers.isCompletelyDisplayed
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
import androidx.test.espresso.matcher.ViewMatchers.isRoot
import androidx.test.espresso.matcher.ViewMatchers.withContentDescription
import androidx.test.espresso.matcher.ViewMatchers.withId
Expand Down Expand Up @@ -146,7 +144,6 @@ class OptionsFragmentTest {

@Before
fun setUp() {
TestPlatformParameterModule.forceEnableLanguageSelectionUi(true)
Intents.init()
setUpTestApplicationComponent()
testCoroutineDispatchers.registerIdlingResource()
Expand Down Expand Up @@ -355,34 +352,6 @@ class OptionsFragmentTest {
}
}

@Test
fun testOptionsFragment_featureEnabled_appLanguageOptionIsDisplayed() {
launch<OptionsActivity>(
createOptionActivityIntent(
internalProfileId = 0,
isFromNavigationDrawer = true
)
).use {
testCoroutineDispatchers.runCurrent()
onView(withId(R.id.app_language_text_view)).check(matches(isDisplayed()))
}
}

@Test
fun testOptionsFragment_featureDisabled_appLanguageOptionIsNotDisplayed() {
TestPlatformParameterModule.forceEnableLanguageSelectionUi(false)

launch<OptionsActivity>(
createOptionActivityIntent(
internalProfileId = 0,
isFromNavigationDrawer = true
)
).use {
testCoroutineDispatchers.runCurrent()
onView(withId(R.id.app_language_text_view)).check(doesNotExist())
}
}

@Test
fun testOptionsFragment_defaultAudioLanguageIsDisplayed() {
launch<OptionsActivity>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import androidx.test.core.app.ActivityScenario.launch
import androidx.test.core.app.ApplicationProvider
import androidx.test.espresso.Espresso.onView
import androidx.test.espresso.action.ViewActions.click
import androidx.test.espresso.assertion.ViewAssertions.doesNotExist
import androidx.test.espresso.assertion.ViewAssertions.matches
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
import androidx.test.espresso.matcher.ViewMatchers.withId
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.google.common.truth.Truth.assertThat
import dagger.Component
Expand Down Expand Up @@ -113,7 +109,6 @@ class OptionsFragmentTest {

@Before
fun setUp() {
TestPlatformParameterModule.forceEnableLanguageSelectionUi(true)
TestPlatformParameterModule.forceEnableEditAccountsOptionsUi(
ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
)
Expand Down Expand Up @@ -160,25 +155,6 @@ class OptionsFragmentTest {
}
}

@Test
fun testOptionsFragment_featureEnabled_appLanguageItemIsDisplayed() {
launch<OptionsActivity>(createOptionActivityIntent(0, true)).use {
testCoroutineDispatchers.runCurrent()

onView(withId(R.id.app_language_item_layout)).check(matches(isDisplayed()))
}
}

@Test
fun testOptionsFragment_featureDisabled_appLanguageItemIsNotDisplayed() {
TestPlatformParameterModule.forceEnableLanguageSelectionUi(false)
launch<OptionsActivity>(createOptionActivityIntent(0, true)).use {
testCoroutineDispatchers.runCurrent()

onView(withId(R.id.app_language_item_layout)).check(doesNotExist())
}
}

@Test
fun testOptionsFragment_clickAppLanguage_checkLoadingTheCorrectFragment() {
launch<OptionsActivity>(createOptionActivityIntent(0, true)).use {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import org.oppia.android.util.platformparameter.ENABLE_DOWNLOADS_SUPPORT_DEFAULT
import org.oppia.android.util.platformparameter.ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_EXTRA_TOPIC_TABS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_INTERACTION_CONFIG_CHANGE_STATE_RETENTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_SPOTLIGHT_UI_DEFAULT_VALUE
Expand All @@ -26,7 +25,6 @@ import org.oppia.android.util.platformparameter.EnableEditAccountsOptionsUi
import org.oppia.android.util.platformparameter.EnableExtraTopicTabsUi
import org.oppia.android.util.platformparameter.EnableFastLanguageSwitchingInLesson
import org.oppia.android.util.platformparameter.EnableInteractionConfigChangeStateRetention
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.EnableLoggingLearnerStudyIds
import org.oppia.android.util.platformparameter.EnablePerformanceMetricsCollection
Expand Down Expand Up @@ -104,14 +102,6 @@ class PlatformParameterAlphaKenyaModule {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableEditAccountsOptionsUi
fun provideEnableEditAccountsOptionsUi(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import org.oppia.android.util.platformparameter.ENABLE_DOWNLOADS_SUPPORT_DEFAULT
import org.oppia.android.util.platformparameter.ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_EXTRA_TOPIC_TABS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_INTERACTION_CONFIG_CHANGE_STATE_RETENTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EXTRA_TOPIC_TABS_UI
Expand All @@ -25,7 +24,6 @@ import org.oppia.android.util.platformparameter.EnableEditAccountsOptionsUi
import org.oppia.android.util.platformparameter.EnableExtraTopicTabsUi
import org.oppia.android.util.platformparameter.EnableFastLanguageSwitchingInLesson
import org.oppia.android.util.platformparameter.EnableInteractionConfigChangeStateRetention
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.EnableLoggingLearnerStudyIds
import org.oppia.android.util.platformparameter.EnablePerformanceMetricsCollection
Expand Down Expand Up @@ -101,14 +99,6 @@ class PlatformParameterAlphaModule {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableEditAccountsOptionsUi
fun provideEnableEditAccountsOptionsUi(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import org.oppia.android.util.platformparameter.ENABLE_DOWNLOADS_SUPPORT_DEFAULT
import org.oppia.android.util.platformparameter.ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_EXTRA_TOPIC_TABS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_INTERACTION_CONFIG_CHANGE_STATE_RETENTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_SPOTLIGHT_UI_DEFAULT_VALUE
Expand All @@ -26,7 +25,6 @@ import org.oppia.android.util.platformparameter.EnableEditAccountsOptionsUi
import org.oppia.android.util.platformparameter.EnableExtraTopicTabsUi
import org.oppia.android.util.platformparameter.EnableFastLanguageSwitchingInLesson
import org.oppia.android.util.platformparameter.EnableInteractionConfigChangeStateRetention
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.EnableLoggingLearnerStudyIds
import org.oppia.android.util.platformparameter.EnablePerformanceMetricsCollection
Expand Down Expand Up @@ -103,14 +101,6 @@ class PlatformParameterModule {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableEditAccountsOptionsUi
fun provideEnableEditAccountsOptionsUi(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ import org.oppia.android.util.logging.GlobalLogLevel
import org.oppia.android.util.logging.LogLevel
import org.oppia.android.util.logging.SyncStatusModule
import org.oppia.android.util.networking.NetworkConnectionUtilDebugModule
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.PlatformParameterValue
import org.oppia.android.util.platformparameter.SPLASH_SCREEN_WELCOME_MSG_DEFAULT_VALUE
Expand Down Expand Up @@ -370,14 +368,6 @@ class LoggingIdentifierControllerTest {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableLearnerStudyAnalytics
fun provideLearnerStudyAnalytics(): PlatformParameterValue<Boolean> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ import org.oppia.android.util.logging.GlobalLogLevel
import org.oppia.android.util.logging.LogLevel
import org.oppia.android.util.logging.SyncStatusModule
import org.oppia.android.util.networking.NetworkConnectionUtilDebugModule
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.PlatformParameterValue
import org.oppia.android.util.platformparameter.SPLASH_SCREEN_WELCOME_MSG_DEFAULT_VALUE
Expand Down Expand Up @@ -391,14 +389,6 @@ class OppiaLoggerTest {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableLearnerStudyAnalytics
fun provideLearnerStudyAnalytics(): PlatformParameterValue<Boolean> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ import org.oppia.android.util.platformparameter.ENABLE_DOWNLOADS_SUPPORT_DEFAULT
import org.oppia.android.util.platformparameter.ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_EXTRA_TOPIC_TABS_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_INTERACTION_CONFIG_CHANGE_STATE_RETENTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.ENABLE_PERFORMANCE_METRICS_COLLECTION_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EnableAppAndOsDeprecation
import org.oppia.android.util.platformparameter.EnableDownloadsSupport
import org.oppia.android.util.platformparameter.EnableEditAccountsOptionsUi
import org.oppia.android.util.platformparameter.EnableExtraTopicTabsUi
import org.oppia.android.util.platformparameter.EnableFastLanguageSwitchingInLesson
import org.oppia.android.util.platformparameter.EnableInteractionConfigChangeStateRetention
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.EnableLoggingLearnerStudyIds
import org.oppia.android.util.platformparameter.EnablePerformanceMetricsCollection
Expand Down Expand Up @@ -118,11 +116,6 @@ class TestPlatformParameterModule {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> =
PlatformParameterValue.createDefaultParameter(enableLanguageSelectionUi)

@Provides
@EnableEditAccountsOptionsUi
fun provideEnableEditAccountsOptionsUi(): PlatformParameterValue<Boolean> =
Expand Down Expand Up @@ -272,7 +265,6 @@ class TestPlatformParameterModule {

companion object {
private var enableDownloadsSupport = ENABLE_DOWNLOADS_SUPPORT_DEFAULT_VALUE
private var enableLanguageSelectionUi = ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
private var enableEditAccountsOptionsUi = ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
private var enableLearnerStudyAnalytics = LEARNER_STUDY_ANALYTICS_DEFAULT_VALUE
private var enableFastLanguageSwitchingInLesson =
Expand All @@ -289,18 +281,11 @@ class TestPlatformParameterModule {
NPS_SURVEY_MINIMUM_AGGREGATE_LEARNING_TIME_IN_A_TOPIC_IN_MINUTES_DEFAULT_VALUE
private var gracePeriodInDays = NPS_SURVEY_GRACE_PERIOD_IN_DAYS_DEFAULT_VALUE

/** Enables forcing [EnableLanguageSelectionUi] platform parameter flag from tests. */
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
fun forceEnableDownloadsSupport(value: Boolean) {
enableDownloadsSupport = value
}

/** Enables forcing [EnableLanguageSelectionUi] platform parameter flag from tests. */
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
fun forceEnableLanguageSelectionUi(value: Boolean) {
enableLanguageSelectionUi = value
}

/** Enables forcing [EnableEditAccountsOptionsUI] platform parameter flag from tests. */
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
fun forceEnableEditAccountsOptionsUi(value: Boolean) {
Expand Down Expand Up @@ -352,7 +337,6 @@ class TestPlatformParameterModule {
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
fun reset() {
enableDownloadsSupport = ENABLE_DOWNLOADS_SUPPORT_DEFAULT_VALUE
enableLanguageSelectionUi = ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
enableEditAccountsOptionsUi = ENABLE_EDIT_ACCOUNTS_OPTIONS_UI_DEFAULT_VALUE
enableLearnerStudyAnalytics = LEARNER_STUDY_ANALYTICS_DEFAULT_VALUE
enableFastLanguageSwitchingInLesson = FAST_LANGUAGE_SWITCHING_IN_LESSON_DEFAULT_VALUE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ const val SYNC_UP_WORKER_TIME_PERIOD_IN_HOURS = "sync_up_worker_time_period"
* [PlatformParameterSyncUpWorker] will run again.
*/
const val SYNC_UP_WORKER_TIME_PERIOD_IN_HOURS_DEFAULT_VALUE = 12

/**
* Qualifier for the platform parameter that controls whether to cache LaTeX rendering using Glide.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import org.oppia.android.util.data.DataProvidersInjector
import org.oppia.android.util.data.DataProvidersInjectorProvider
import org.oppia.android.util.locale.LocaleProdModule
import org.oppia.android.util.networking.NetworkConnectionUtilDebugModule
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLearnerStudyAnalytics
import org.oppia.android.util.platformparameter.PlatformParameterValue
import org.oppia.android.util.platformparameter.SPLASH_SCREEN_WELCOME_MSG_DEFAULT_VALUE
Expand Down Expand Up @@ -109,14 +107,6 @@ class SyncStatusManagerImplTest : SyncStatusManagerTestBase() {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableLearnerStudyAnalytics
fun provideLearnerStudyAnalytics(): PlatformParameterValue<Boolean> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ import org.oppia.android.util.logging.LoggerModule
import org.oppia.android.util.logging.SyncStatusModule
import org.oppia.android.util.logging.performancemetrics.PerformanceMetricsEventLogger
import org.oppia.android.util.networking.NetworkConnectionUtilDebugModule
import org.oppia.android.util.platformparameter.ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
import org.oppia.android.util.platformparameter.EnableLoggingLearnerStudyIds
import org.oppia.android.util.platformparameter.PlatformParameterValue
import org.oppia.android.util.platformparameter.SPLASH_SCREEN_WELCOME_MSG_DEFAULT_VALUE
Expand Down Expand Up @@ -99,14 +97,6 @@ class LogReportingModuleTest {
)
}

@Provides
@EnableLanguageSelectionUi
fun provideEnableLanguageSelectionUi(): PlatformParameterValue<Boolean> {
return PlatformParameterValue.createDefaultParameter(
ENABLE_LANGUAGE_SELECTION_UI_DEFAULT_VALUE
)
}

@Provides
@EnableLoggingLearnerStudyIds
fun provideLoggingLearnerStudyIds(): PlatformParameterValue<Boolean> {
Expand Down
Loading