Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag

[kmanikanta335]

Explanation

Fix #5225

Remove declarations and usages of the EnableLanguageSelectionUi PlatformParameter.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)

• Any changes to scripts/assets files have their rationale included in the PR explanation.

• The PR follows the style guide.

• The PR does not contain any unnecessary code changes from Android Studio (reference).

• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".

• The PR is assigned to the appropriate reviewers (reference).

[adhiamboperes]

Hi @kmanikanta335, thanks for your PR.

According to the CI results(see: https://github.com/oppia/oppia-android/wiki/Interpreting-CI-Results), you still have leftover refrences to the removed platform param. Use Ctrl+Shift+F to search for all usages.

Additionally, please deploy the app locally to confirm nothing is broken, before pushing new commits.

[adhiamboperes]

@kmanikanta335 per the CI results I can see two failing tests for this platform param being disabled. These tests should be removed because we nolonger have this feature flag. testOptionsFragment_featureDisabled_appLanguageOptionIsNotDisplayed.
We have two OptionsFragmentTest files.

[adhiamboperes]

@kmanikanta335, please resolve the merge conflict, and also upload a screenshot confirming that the failing test is passing locally on your machine.

Once done, please assign the PR back to me.

[adhiamboperes]

@kmanikanta335, could you please focus on completing this PR before beginning to work on other issues? Please ask questions in case you need some assistance.

[kmanikanta335]

@adhiamboperes
can you please help in these failing checks

[adhiamboperes]

@kmanikanta335 per the CI results I can see two failing tests for this platform param being disabled. These tests should be removed because we nolonger have this feature flag. testOptionsFragment_featureDisabled_appLanguageOptionIsNotDisplayed. We have two OptionsFragmentTest files.

I left a comment here explaining what needs to be done. Please let me know of any specific questions that I clarify on.

[adhiamboperes]

@kmanikanta335, I reviewed your changes and you still haven't fully addressed my previous comment. You still have a failing test.

[kmanikanta335]

@adhiamboperes I hope now its done

[kmanikanta335]

@adhiamboperes pls review it

[oppiabot]

Hi @kmanikanta335, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[oppiabot]

Hi @kmanikanta335, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[adhiamboperes]

Thanks @kmanikanta335, this LGTM!