Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3384 : Arrange strings file #5236

Closed
wants to merge 102 commits into from
Closed

Fix #3384 : Arrange strings file #5236

wants to merge 102 commits into from

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Nov 18, 2023

Explanation

Fix #3384 : Arrange strings file as per below criteria:

Screen/Toolbar Titles
Used in manifest label, toolbar title and activity label test.
Pattern: activity_name_activity_title

Example: administrator_controls_activty_title

App Content Strings
Pattern: activity_name_view_component_type

administrator_controls_activity_profile_management_label
administrator_controls_activity_account_actions_label
administrator_controls_activity_logout_item_text
administrator_controls_activity_app_version_item

Shared Strings
Pattern: view_component_description

reading_text_size_item_text_small
reading_text_size_item_medium

Test Strings
Pattern: test_file_name_view_component_type

Dialogs
Pattern: dialog_name_view_component_type

Grouping Pattern:

<!-- AdministratorControlActivity -->
….
….
<!-- GeneralAvailabilityUpgradeNoticeDialogFragment -->
…..
<!-- ProgressDatabaseFullDialog -->

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@MohitGupta121 MohitGupta121 requested review from a team as code owners November 18, 2023 12:54
@MohitGupta121 MohitGupta121 self-assigned this Nov 18, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121! I took a first pass to verify the general patterns that we had agreed on. There are some small changes needed.

Additionally, can we move GeneralStrings and SharedStrings sections to the bottom of the strings files, so that the screen based sections come first?

Lastly, please update the PR description as discussed.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@MohitGupta121
Copy link
Member Author

Deleting this PR because of unnecessary commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrange string resources based on screens
2 participants