-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3384 : Arrange strings file #5252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes PTAL, I updated this PR as we discussed along with the review suggestions from last #5236 (review) review comments. You should contiune the review from those comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, I took a pass, the previous comments have been sufficiently adressed. I just had a couple more.
Please fix the merge conflicts as well.
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@adhiamboperes @BenHenning could you please reopen this PR and pass your final review @BenHenning |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@MohitGupta121, could you please resolve the conflics here? @XichengSpencer, PTAL for a review pass. |
<string name="walkthrough_activity_pick_different_topic_text">Pick a \ndifferent topic.</string> | ||
<string name="walkthrough_activity_are_you_interested_text">Are you interested in:\n%s?</string> | ||
<string name="walkthrough_activity_back_button_text">Back Button</string> | ||
<!-- GeneralStrings --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String in this section maybe needs a bit of alphabetical arrangement
Hi @MohitGupta121, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fix #3384 : Arrange strings file as per below criteria:
Screen/Toolbar Titles
Used in manifest label, toolbar title and activity label test.
Pattern:
activity_name_activity_title
Example:
administrator_controls_activty_title
App Content Strings
Pattern:
activity_name_view_component_type
administrator_controls_activity_profile_management_label
administrator_controls_activity_account_actions_label
administrator_controls_activity_logout_item_text
administrator_controls_activity_app_version_item
Shared Strings
Pattern:
view_component_description
reading_text_size_item_text_small
reading_text_size_item_medium
Test Strings
Pattern:
test_file_name_view_component_type
Dialogs
Pattern:
dialog_name_view_component_type
Grouping Pattern:
<!-- AdministratorControlActivity -->
….
….
<!-- GeneralAvailabilityUpgradeNoticeDialogFragment -->
…..
<!-- ProgressDatabaseFullDialog -->
Essential Checklist