Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5142 Edit text foreground and background contrast ratio issue in Light mode #5144

Merged
merged 4 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/res/color/component_color_textlayout.xml
adhiamboperes marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:color="@color/color_palette_edit_text_inactive_color" android:state_focused="false"/>
<item android:color="@color/color_palette_edit_text_active_color" android:state_focused="true"/>
</selector>
Vishwajith-Shettigar marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions app/src/main/res/values-night/color_palette.xml
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,6 @@
<color name="color_palette_nps_selected_text_color">@color/color_def_white</color>
<color name="color_palette_nps_selected_background_color">@color/color_def_oppia_green</color>
<color name="color_palette_nps_unselected_background_color">@color/color_def_pale_green</color>
<color name="color_palette_edit_text_inactive_color">@color/color_def_black_87</color>
<color name="color_palette_edit_text_active_color">@color/color_def_white</color>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values/color_palette.xml
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,6 @@
<color name="color_palette_survey_disabled_button_text_color">@color/color_def_chooser_grey</color>
<color name="color_palette_button_text_color">@color/color_def_persian_green</color>
<color name="color_palette_edit_text_unselected_color">@color/color_def_grey</color>
<color name="color_palette_edit_text_inactive_color">@color/color_def_black_87</color>
<color name="color_palette_edit_text_active_color">@color/color_def_black_87</color>
</resources>
2 changes: 1 addition & 1 deletion app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
<item name="boxCornerRadiusBottomStart">@dimen/text_input_layout_corner_radius</item>
<item name="boxCornerRadiusTopEnd">@dimen/text_input_layout_corner_radius</item>
<item name="boxCornerRadiusTopStart">@dimen/text_input_layout_corner_radius</item>
<item name="boxStrokeColor">@color/component_color_shared_text_input_layout_stroke_color</item>
<item name="boxStrokeColor">@color/component_color_textlayout</item>
<item name="boxStrokeWidth">@dimen/text_input_layout_stroke_width</item>
<item name="errorEnabled">true</item>
<item name="errorIconTint">@color/component_color_shared_text_input_layout_error_color</item>
Expand Down
Loading