-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5142 Edit text foreground and background contrast ratio issue in Light mode #5144
Fix #5142 Edit text foreground and background contrast ratio issue in Light mode #5144
Conversation
@adhiamboperes PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar!
I have left some suggestions, but this looks okay.
Could you also just add the screen recordings so that we can see the active/inactive state color changes in action?
I added Screen recordings,thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks @Vishwajith-Shettigar!
Hi @Vishwajith-Shettigar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fix #5142, changed text input default stroke color.
Added color resource file names component_color_text_layout.xml in order to give stroke color
Essential Checklist
For UI-specific PRs only
Berore fix
Afterfix
Screen recording after fix
Light mode
WhatsApp.Video.2023-09-07.at.7.37.05.AM.mp4
Dark mode
WhatsApp.Video.2023-09-07.at.7.37.04.AM.mp4
If your PR includes UI-related changes, then: