Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5142 Edit text foreground and background contrast ratio issue in Light mode #5144

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Sep 6, 2023

Explanation

Fix #5142, changed text input default stroke color.
Added color resource file names component_color_text_layout.xml in order to give stroke color

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Berore fix

Light mode Dark mode
contarstlight_before contastdark_before

Afterfix

Light mode Dark mode
newnew contrastdark_after

Screen recording after fix

Light mode

WhatsApp.Video.2023-09-07.at.7.37.05.AM.mp4

Dark mode

WhatsApp.Video.2023-09-07.at.7.37.04.AM.mp4

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar Vishwajith-Shettigar requested a review from a team as a code owner September 6, 2023 09:38
@Vishwajith-Shettigar Vishwajith-Shettigar changed the title contrast issue fixed Fix #5142 Edit text foreground and background contrast ratio issue in Light mode Sep 6, 2023
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes PTAL

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar!
I have left some suggestions, but this looks okay.

Could you also just add the screen recordings so that we can see the active/inactive state color changes in action?

app/src/main/res/color/component_color_textlayout.xml Outdated Show resolved Hide resolved
app/src/main/res/color/component_color_textlayout.xml Outdated Show resolved Hide resolved
@Vishwajith-Shettigar
Copy link
Collaborator Author

Thanks @Vishwajith-Shettigar! I have left some suggestions, but this looks okay.

Could you also just add the screen recordings so that we can see the active/inactive state color changes in action?

I added Screen recordings,thank you.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @Vishwajith-Shettigar!

@oppiabot oppiabot bot added the PR: LGTM label Sep 7, 2023
@oppiabot
Copy link

oppiabot bot commented Sep 7, 2023

Hi @Vishwajith-Shettigar, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@adhiamboperes adhiamboperes reopened this Sep 7, 2023
@adhiamboperes adhiamboperes enabled auto-merge (squash) September 7, 2023 11:55
@adhiamboperes adhiamboperes merged commit a1ba8bd into oppia:develop Sep 7, 2023
37 checks passed
@Vishwajith-Shettigar Vishwajith-Shettigar deleted the contrastissue branch September 7, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Edit text foreground and background contrast ratio issue in Light mode
2 participants