Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 4806 #4808

Closed
wants to merge 6 commits into from
Closed

Resolve 4806 #4808

wants to merge 6 commits into from

Conversation

ShubhadeepKarmakar
Copy link
Collaborator

@ShubhadeepKarmakar ShubhadeepKarmakar commented Dec 28, 2022

We can successfully set a profile image from the gallery and the CREATE button work properly.
Resolved #4806

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Video after resolved:
https://user-images.githubusercontent.com/99060332/209754709-b364bc5e-4f79-4a4d-9e0d-11860c2b6feb.mp4

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

@oppiabot
Copy link

oppiabot bot commented Jan 4, 2023

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 4, 2023
@ShubhadeepKarmakar
Copy link
Collaborator Author

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

I think there have nothing to commit than the previous pr.

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 10, 2023
@BenHenning
Copy link
Member

@ShubhadeepKarmakar please make sure that your PR is following the normal template that all other PRs use, and has a similar title formatting. Besides that, please make sure to review https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR to see how to ask someone to review and take a first pass at your PR.

@BenHenning BenHenning mentioned this pull request Jan 11, 2023
@ShubhadeepKarmakar
Copy link
Collaborator Author

@ShubhadeepKarmakar please make sure that your PR is following the normal template that all other PRs use, and has a similar title formatting. Besides that, please make sure to review https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR to see how to ask someone to review and take a first pass at your PR.

Well, I'm trying.

@oppiabot
Copy link

oppiabot bot commented Jan 18, 2023

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 18, 2023
@oppiabot oppiabot bot closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to select a profile image from the gallery while Adding profile
2 participants