Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select a profile image from the gallery while Adding profile #4806

Closed
shubham419 opened this issue Dec 27, 2022 · 11 comments
Closed

Comments

@shubham419
Copy link

Describe the bug
when we select a image from gallery while adding new profile, And after that click on create button it does not responce and new profile is not added.

To Reproduce
Steps to reproduce the behavior:

  1. open app
  2. Click on add profile button
  3. enter administrator's pin
  4. click on round profile image view
  5. select image from gallery
  6. enter name
  7. and click create button

Expected behavior
It shuld successfully create new user with the choosen profile image.

Demonstration

Untitled.mp4

Environment

  • Device/emulator being used: POCO X2
  • Android : Android 11
  • App version : 1
@shubham419
Copy link
Author

Hi i come across this issue, and i tried to solve it and also find easy solution for #4803 issue.

@ShubhadeepKarmakar
Copy link
Collaborator

Hey, can I work on it?

@shubham419
Copy link
Author

@ShubhadeepKarmakar I have created a pull request, check whether my solution is correct or not

@BenHenning
Copy link
Member

Just to clarify @shubham419 is it the case that the create button isn't doing anything when tapped after selecting a profile image? And to check: are you able to create profile images when not selecting a profile image?

@SidharthMudgil
Copy link

Can you assign this issue to me?

@seanlip
Copy link
Member

seanlip commented Feb 15, 2023

@SidharthMudgil Please follow the instructions here for claiming an issue. You will need to provide an explanation of how you would fix it, and (if possible) a demo of the working fix.

I would also recommend reading and following the other instructions on that page if you haven't already done so. Thanks!

@ShubhadeepKarmakar
Copy link
Collaborator

Hey is it fixed? If not, then I would like to work on it.

@seanlip
Copy link
Member

seanlip commented Feb 17, 2023

@ShubhadeepKarmakar See my previous comment in this thread for instructions on how to claim an issue.

You should be able to check directly on your local version of the app whether it is fixed or not.

@SidharthMudgil
Copy link

@BenHenning Hi, I also come up with this solution #4808, it works can you tell me why it was not merged so I can focus on that

@BenHenning
Copy link
Member

@BenHenning Hi, I also come up with this solution #4808, it works can you tell me why it was not merged so I can focus on that

@SidharthMudgil it looks like there were requested action items from both Oppiabot and me on #4808 that weren't resolved, and then the PR was closed due to inactivity.

@BenHenning
Copy link
Member

Duplicate of #4072.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants