[operator_build] Update the go.mod replace to use local repos #3400
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
2 times, most recently
from
5b9f9c1 to
83c2189
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7a72b048f75a4011912d2ff2977d5e87 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 56s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9a09a5bbe0c7410e8e747c753fb7993c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 51s |
When building from a PR that has multiple dependencies in the same repo, the incorrect versions are built. This happens because the build tasks extract a sha from an operators list that is built from zuul.items, which contains a list of the dependencies on a PR (from Depends-On). This list can contain multiple PRs from the same repo, however, the operator list only takes the first item for each repo. The information is used to update the openstack-operator go.mod file with a "replaces" directive that tell it where to find the operators to deploy. The line being added was referencing a particular commit on the PR source branch previously. This is incorrect when using zuul, as zuul uses speculative merging and prepares a version of the repositories that have all the dependencies merged together. The "replaces" is updated to reference the local version of the operator i.e. the one prepared by zuul.
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
2 times, most recently
from
074d610 to
8680100
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/26e385ba2472448e87c11f17a6f49532 ❌ openstack-k8s-operators-content-provider FAILURE in 6m 08s |
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
from
8680100 to
e3b7c18
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9098d6c2425244be99409811ce039a03 ❌ openstack-k8s-operators-content-provider FAILURE in 5m 44s |
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
from
e3b7c18 to
cbbc386
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/881569539f47463fae7255ce75bcb814 ❌ openstack-k8s-operators-content-provider FAILURE in 5m 52s |
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
from
cbbc386 to
a876669
Compare
elfiesmelfie
force-pushed
the
efoley_update_operator_build
branch
from
a876669 to
48e85fc
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/83550bf745b24e41b8cc4293eaa911e3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 06s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a7072cdd0b774c4cbb147672b899fdfc ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 11s |
|
This PR is stale because it has been for over 15 days with no activity. |
This is for testing to try work around the issue in openstack-k8s-operators/ci-framework#3400
1 participant
When building from a PR that has multiple dependencies in the same repo, the incorrect versions are built.
This happens because the build tasks extract a sha from an operators list that is built from zuul.items, which contains a list of the dependencies on a PR (from Depends-On). This list can contain multiple PRs from the same repo, however, the operator list only takes the first item for each repo.
The information is used to update the openstack-operator go.mod file with a "replaces" directive that tell it where to find the operators to deploy.
The line being added was referencing a particular commit on the PR source branch previously.
This is incorrect when using zuul, as zuul uses speculative merging and prepares a version of the repositories that have all the dependencies merged together.
The "replaces" is updated to reference the local version of the operator i.e. the one prepared by zuul.