Add Cloudkitty CI Job #777
Conversation
update prometheus_collector config
When the secret is unset, cloudkitty will not start, since there was no default set. The osp-secret is used as the default secret for other services. Thes default value for the cloudkitty secret is updated to match the other service defaults, since the required information (CK password) is expected to be in the same secret as the other services.
Also add mTLS certificates deployment needed for communication between Loki and CloudKitty. All is tested with kuttl-tests, some minor fixes across CloudKitty related code included (other needed fixes were discussed and will follow in the future). EnsureWatches was moved from metricstorage_controller into pkg/utils. All calls to this function throughout the whole metric storage controller needed to be modified to point to the new location, but other than that there aren't any changes to the metric storage controller.
The s3StorageConfig.secret is passed to Lokistack, which requires some value be set. The default is needed, or else there will be an error when it is not configured. The default is set to a reasonable value for the secret name (cloudkitty-loki-s3) and the type (s3), which match the values we're planning on using for the CI environment. Lines added: 1 Lines generated: 16
The healthcheck for cloudkitty-proc/probe was failing because the CA was not trusted. The TLS-related file were not available in the expected location in the container. The kolla_set_config command is used so that the mounted config files get copied into the expected location for the healthcheck. The command was updated to use 'bash -c' so that both the kolla_set_config and the healthcheck command would be run on startup. [API] Update script used in uwsgi template The script location changed between antelope and master containers. In both cases, it exists in the same alternative location Update initial delay on liveness and readiness probes This give a chance for the api to start up before the first healthcheck [API] Add metrics.yaml into the api pod
…_default_secret [CloudKitty] Add osp-secret as the default for secret
…_loki [cloudkitty] Add LokiStack deployment
When the secret is unset, cloudkitty will not start, since there was no default set. The osp-secret is used as the default secret for other services. Thes default value for the cloudkitty secret is updated to match the other service defaults, since the required information (CK password) is expected to be in the same secret as the other services.
Also add mTLS certificates deployment needed for communication between Loki and CloudKitty. All is tested with kuttl-tests, some minor fixes across CloudKitty related code included (other needed fixes were discussed and will follow in the future). EnsureWatches was moved from metricstorage_controller into pkg/utils. All calls to this function throughout the whole metric storage controller needed to be modified to point to the new location, but other than that there aren't any changes to the metric storage controller.
The s3StorageConfig.secret is passed to Lokistack, which requires some value be set. The default is needed, or else there will be an error when it is not configured. The default is set to a reasonable value for the secret name (cloudkitty-loki-s3) and the type (s3), which match the values we're planning on using for the CI environment. Lines added: 1 Lines generated: 16
…perator into cloudkitty_separate
TODO: update the deploy_logging_dependencies role
When running in CI, with a differently named CR, the defaults are not set for Telemetry - 'The Telemetry "telemetry-ck" is invalid: ' - '* spec.autoscaling.aodh.apiImage: Required value' - '* spec.autoscaling.aodh.evaluatorImage: Required value' - '* spec.autoscaling.aodh.listenerImage: Required value' - '* spec.autoscaling.aodh.notifierImage: Required value' - '* spec.ceilometer.centralImage: Required value' - '* spec.ceilometer.computeImage: Required value' - '* spec.ceilometer.ipmiImage: Required value' - '* spec.ceilometer.notificationImage: Required value' - '* spec.ceilometer.proxyImage: Required value' - '* spec.ceilometer.sgCoreImage: Required value' WORKAROUND: telemetry-with-cloudkitty is updated to explicitly add these values
Loki-operator needs to be pinned to 6.3.0, because 6.3.1 has this issue: https://issues.redhat.com/browse/LOG-7752
Try alternative way to get installplan Add retries to installplan check If there's no value returned, the rc is still 0, so we need to explicitly state the success criteria
…n be passed through
Add kustomization for oscp to enable CK pre-deploy Move loki installation to pre_deploy.
…et is not present
…ey/cloud-kitty-job
Set the storageClass to crc-csi-hostpath-provisioner for CloudKitty deployment in CRC-based CI jobs. This prevents the need to increase PVC allocations in install_yamls by using the default storage class available in CRC, which allocates storage as required.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ayefimov-1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ayefimov-1. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This change depends on a change that failed to merge. Changes https://review.opendev.org/c/openstack/cloudkitty/+/961609, openstack-k8s-operators/install_yamls#1088, openstack-k8s-operators/openstack-operator#1614, infrawatch/feature-verification-tests#315 are needed. |
| kind: Subscription | ||
| metadata: | ||
| name: observability-operator | ||
| # name: observability-operator # removed per Juan |
There was a problem hiding this comment.
I'm pretty sure this won't work, since name is actually required field.
|
/ok-to-test |
|
@ayefimov-1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Create a new Zuul CI Job that will run Cloudkitty tempest tests.
Last change in CK
Depends-On: https://review.opendev.org/c/openstack/cloudkitty/+/961609
Depends-On: openstack-k8s-operators/install_yamls#1088
merged: openstack-k8s-operators/tcib#328
Add cloudkitty-tempest package to openstack-tempest-all (Requires using tempest master image)
https://review.rdoproject.org/r/c/openstack/tempest-distgit/+/58015
merged: Related change: openstack-k8s-operators/test-operator#340
telemetry-operator change: #741
openstack-operator change: (Merge Conflicts)
Depends-On: openstack-k8s-operators/openstack-operator#1614
The openstack-operator is getting updated to reference the wrong version of telemetry-operator, which doesn't have CK available. This cifmw change will hopefully fix it. This is only an issue because we're using Depends-On to add a dependency on multiple changes from the same operator repo (i.e. telemetry-operator)
Add CK to patch-openstack-versions
Depends-On: infrawatch/feature-verification-tests#315
openstack-k8s-operators/ci-framework#3400