Skip to content

OCPBUGS-63383: Fix empty operator name #30407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
+4 −4
Merged

OCPBUGS-63383: Fix empty operator name #30407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
594889e
Fix empty operator name
weliang1 Oct 22, 2025
665de6c
Fix typo
weliang1 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/monitortests/network/legacynetworkmonitortests/networking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ func testPodSandboxCreation(events monitorapi.Intervals, clientConfig *rest.Conf
event.Locator.OldLocator(), progressingOperatorName, event.Message.OldMessage()))
} else {
failures = append(failures, fmt.Sprintf(
"%v - never deleted - operator:%s was progressing which may cause pod sandbox creation errors - %v",
event.Locator.OldLocator(), progressingOperatorName, event.Message.OldMessage()))
"%v - never deleted - %v",
event.Locator.OldLocator(), event.Message.OldMessage()))
}
} else {
timeBetweenDeleteAndFailure := event.From.Sub(*deletionTime)
Expand All @@ -209,10 +209,10 @@ func testPodSandboxCreation(events monitorapi.Intervals, clientConfig *rest.Conf
// withing five seconds, it ought to be long enough to know, but it's close enough to flake and not fail
flakes = append(flakes, fmt.Sprintf("%v - %0.2f seconds after deletion - %v", event.Locator.OldLocator(), timeBetweenDeleteAndFailure.Seconds(), event.Message.OldMessage()))
case deletionTime.Before(event.From):
// something went wrong. More than five seconds after the pod ws deleted, the CNI is trying to set up pod sandboxes and can't
// something went wrong. More than five seconds after the pod was deleted, the CNI is trying to set up pod sandboxes and can't
failures = append(failures, fmt.Sprintf("%v - %0.2f seconds after deletion - %v", event.Locator.OldLocator(), timeBetweenDeleteAndFailure.Seconds(), event.Message.OldMessage()))
default:
// something went wrong. deletion happend after we had a failure to create the pod sandbox
// something went wrong. deletion happened after we had a failure to create the pod sandbox
failures = append(failures, fmt.Sprintf("%v - deletion came AFTER sandbox failure - %v", event.Locator.OldLocator(), event.Message.OldMessage()))
}
}
Expand Down