Skip to content

OCPBUGS-63383: Fix empty operator name #30407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-63383: Fix empty operator name #30407

wants to merge 2 commits into from
+4 −4

Conversation

@weliang1
Copy link
Contributor

There's actually a bug on line 200: it still references progressingOperatorName which would be empty in the else block, so the error message would show operator: with no operator name.

Prow CI Job:
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade/1980072090157453312

Test Log:

namespace/openshift-insights node/ci-op-w0p8d153-53ca2-t757n-worker-centralus1-8gsmj pod/insights-runtime-extractor-7ksdk hmsg/e979fe1238 - never deleted - operator: was progressing which may cause pod sandbox creation errors - firstTimestamp/2025-10-20T02:22:18Z interesting/true lastTimestamp/2025-10-20T02:22:18Z reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_insights-runtime-extractor-7ksdk_openshift-insights_a2988964-4266-43b0-bcb8-e72879d1be3a_0(5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc): error adding pod openshift-insights_insights-runtime-extractor-7ksdk to CNI network "multus-cni-network": plugin type="multus-shim" name="multus-cni-network" failed (add): CmdAdd (shim): CNI request failed with status 400: 'ContainerID:"5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc" Netns:"/var/run/netns/bd21c728-1476-4be1-8e36-9a7614f4306c" IfName:"eth0" Args:"IgnoreUnknown=1;K8S_POD_NAMESPACE=openshift-insights;K8S_POD_NAME=insights-runtime-extractor-7ksdk;K8S_POD_INFRA_CONTAINER_ID=5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc;K8S_POD_UID=a2988964-4266-43b0-bcb8-e72879d1be3a" Path:"" ERRORED: error configuring pod [openshift-insights/insights-runtime-extractor-7ksdk] networking: Multus: [openshift-insights/insights-runtime-extractor-7ksdk/a2988964-4266-43b0-bcb8-e72879d1be3a]: error setting the networks status: SetPodNetworkStatusAnnotation: failed to update the pod insights-runtime-extractor-7ksdk in out of cluster comm: SetNetworkStatus: failed to update the pod insights-runtime-extractor-7ksdk in out of cluster comm: status update failed for pod openshift-insights/insights-runtime-extractor-7ksdk: etcdserver: request timed out, possibly due to previous leader failure
': StdinData: {"auxiliaryCNIChainName":"vendor-cni-chain","binDir":"/var/lib/cni/bin","clusterNetwork":"/host/run/multus/cni/net.d/10-ovn-kubernetes.conf","cniVersion":"0.3.1","daemonSocketDir":"/run/multus/socket","globalNamespaces":"default,openshift-multus,openshift-sriov-network-operator,openshift-cnv","logLevel":"verbose","logToStderr":true,"name":"multus-cni-network","namespaceIsolation":true,"type":"multus-shim"}}

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial October 22, 2025 02:07
@weliang1
Copy link
Contributor Author

/retitle OCPBUGS-63383: Fix empty operator name

@openshift-ci openshift-ci bot changed the title [OCPBUGS-63383]: Fix empty operator name OCPBUGS-63383: Fix empty operator name Oct 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 22, 2025
@openshift-ci-robot
Copy link

@weliang1: This pull request references Jira Issue OCPBUGS-63383, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

There's actually a bug on line 200: it still references progressingOperatorName which would be empty in the else block, so the error message would show operator: with no operator name.

Prow CI Job:
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade/1980072090157453312

Test Log:

namespace/openshift-insights node/ci-op-w0p8d153-53ca2-t757n-worker-centralus1-8gsmj pod/insights-runtime-extractor-7ksdk hmsg/e979fe1238 - never deleted - operator: was progressing which may cause pod sandbox creation errors - firstTimestamp/2025-10-20T02:22:18Z interesting/true lastTimestamp/2025-10-20T02:22:18Z reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_insights-runtime-extractor-7ksdk_openshift-insights_a2988964-4266-43b0-bcb8-e72879d1be3a_0(5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc): error adding pod openshift-insights_insights-runtime-extractor-7ksdk to CNI network "multus-cni-network": plugin type="multus-shim" name="multus-cni-network" failed (add): CmdAdd (shim): CNI request failed with status 400: 'ContainerID:"5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc" Netns:"/var/run/netns/bd21c728-1476-4be1-8e36-9a7614f4306c" IfName:"eth0" Args:"IgnoreUnknown=1;K8S_POD_NAMESPACE=openshift-insights;K8S_POD_NAME=insights-runtime-extractor-7ksdk;K8S_POD_INFRA_CONTAINER_ID=5af29f2c3f6269c7be21f1bb4501bf7f4cad9956f1bce5fea427f8ea65bb25bc;K8S_POD_UID=a2988964-4266-43b0-bcb8-e72879d1be3a" Path:"" ERRORED: error configuring pod [openshift-insights/insights-runtime-extractor-7ksdk] networking: Multus: [openshift-insights/insights-runtime-extractor-7ksdk/a2988964-4266-43b0-bcb8-e72879d1be3a]: error setting the networks status: SetPodNetworkStatusAnnotation: failed to update the pod insights-runtime-extractor-7ksdk in out of cluster comm: SetNetworkStatus: failed to update the pod insights-runtime-extractor-7ksdk in out of cluster comm: status update failed for pod openshift-insights/insights-runtime-extractor-7ksdk: etcdserver: request timed out, possibly due to previous leader failure
': StdinData: {"auxiliaryCNIChainName":"vendor-cni-chain","binDir":"/var/lib/cni/bin","clusterNetwork":"/host/run/multus/cni/net.d/10-ovn-kubernetes.conf","cniVersion":"0.3.1","daemonSocketDir":"/run/multus/socket","globalNamespaces":"default,openshift-multus,openshift-sriov-network-operator,openshift-cnv","logLevel":"verbose","logToStderr":true,"name":"multus-cni-network","namespaceIsolation":true,"type":"multus-shim"}}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weliang1
Copy link
Contributor Author

/test images

@weliang1
Copy link
Contributor Author

/cc @davegord
/cc @neisw

@openshift-ci openshift-ci bot requested review from davegord and neisw October 23, 2025 13:50
@weliang1
Copy link
Contributor Author

/retest

@openshift-trt
Copy link

openshift-trt bot commented Oct 23, 2025

Job Failure Risk Analysis for sha: 665de6c

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (25) are below the historical average (1707): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 665de6c

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift High - "Import the release payload "nightly-arm64" from an external source" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial High - "Import the release payload "nightly-arm64" from an external source" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 665de6c

  • "Import the release payload "nightly-arm64" from an external source" [Total: 4, Pass: 4, Fail: 0, Flake: 0]

@weliang1
Copy link
Contributor Author

/test e2e-aws-ovn-serial-2of2

@weliang1
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, weliang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
@weliang1
Copy link
Contributor Author

/verified later @weliang

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 24, 2025
@openshift-ci-robot
Copy link

@weliang1: This PR has been marked to be verified later by @weliang.

In response to this:

/verified later @weliang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 367ab40 and 2 for PR HEAD 665de6c in total

@weliang1
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@weliang1
Copy link
Contributor Author

/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@weliang1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 665de6c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@weliang1
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@davegord davegord Awaiting requested review from davegord

@neisw neisw Awaiting requested review from neisw

Assignees

@dgoodwin dgoodwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weliang1 @openshift-ci-robot @dgoodwin