Skip to content

OCPBUGS-33123: update matchLabels values to strings #95249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-33123: update matchLabels values to strings #95249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/nw-ingress-sharding-namespace-labels.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
node-role.kubernetes.io/worker: ""
namespaceSelector:
matchLabels:
type: sharded
type: "sharded"
----
<1> Specify a domain to be used by the Ingress Controller. This domain must be different from the default Ingress Controller domain.

Expand Down
4 changes: 2 additions & 2 deletions modules/nw-ingress-sharding-route-labels.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
node-role.kubernetes.io/worker: ""
routeSelector:
matchLabels:
type: sharded
type: "sharded"
----
<1> Specify a domain to be used by the Ingress Controller. This domain must be different from the default Ingress Controller domain.

Expand All @@ -54,4 +54,4 @@ The Ingress Controller selects routes in any namespace that have the label
[source,terminal]
----
$ oc expose svc <service-name> --hostname <route-name>.apps-sharded.basedomain.example.net
----
----
4 changes: 2 additions & 2 deletions modules/nw-traditional-sharding.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- ops
----

An example of a configured Ingress Controller `dev-router` that has the label selector `spec.namespaceSelector.matchLabels.name` with the key value set to `dev`:
An example of a configured Ingress Controller `dev-router` that has the label selector `spec.namespaceSelector.matchLabels.name` with the key value set to `"dev"`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the phrase "label selector" follow spec.namespaceSelector.matchLabels.name? For example, "...that has the spec.namespaceSelector.matchLabels.name label selector with the key value set to "dev":"


.Example YAML definition for `dev-router`
[source,yaml]
Expand All @@ -39,7 +39,7 @@ metadata:
spec:
namespaceSelector:
matchLabels:
name: dev
name: "dev"
----

If all application routes are in separate namespaces, such as each labeled with `name:finance`, `name:ops`, and `name:dev`, the configuration effectively distributes your routes between the two Ingress Controllers. {product-title} routes for console, authentication, and other purposes should not be handled.
Expand Down