OCPBUGS-33123: update matchLabels values to strings

[jldohmann]

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-33123

Link to docs preview:

• traditional sharding example: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-traditional-sharding_configuring-ingress-cluster-traffic-ingress-controller
• sharding with route labels: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-ingress-sharding-route-labels_configuring-ingress-cluster-traffic-ingress-controller
• sharding with namespace labels: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-ingress-sharding-namespace-labels_configuring-ingress-cluster-traffic-ingress-controller

QE review:

• QE has approved this change.

Additional information:

[openshift-ci-robot]

@jldohmann: This pull request references Jira Issue OCPBUGS-33123, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-33123

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jldohmann]

@lihongan could you PTAL at this docs PR for QE ack? this PR updates the values for matchLabels fields to be strings. thank you 🙇

[ocpdocs-previewbot]

🤖 Wed Jun 25 21:50:44 - Prow CI generated the docs preview:

https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html

[openshift-ci]

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lihongan]

@jldohmann I add comment to the bug, indeed we don't need add " for the value of matchLabels.
There are two ways to set namespaceSelector or routeSelector, one is using matchLabels and it looks like

spec:
  namespaceSelector:
    matchLabels:
      name: dev

Another is using matchExpressions and it looks like

spec:
  namespaceSelector:
    matchExpressions:
    - key: name
      operator: In
      values:
      - dev
      - ops

But the wrong example is:

spec:
  namespaceSelector:
    matchLabels:
      name:
        - finance
        - ops

[lahinson]

Just one question for you. Otherwise, LGTM!

[lahinson]

Should the phrase "label selector" follow spec.namespaceSelector.matchLabels.name? For example, "...that has the spec.namespaceSelector.matchLabels.name label selector with the key value set to "dev":"

[jldohmann]

thank you Hongan, I think i'll close this PR and open a new one since I need to change the base branch anyway

[openshift-ci-robot]

@jldohmann: This pull request references Jira Issue OCPBUGS-33123. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-33123

Link to docs preview:

• traditional sharding example: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-traditional-sharding_configuring-ingress-cluster-traffic-ingress-controller
• sharding with route labels: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-ingress-sharding-route-labels_configuring-ingress-cluster-traffic-ingress-controller
• sharding with namespace labels: https://95249--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.html#nw-ingress-sharding-namespace-labels_configuring-ingress-cluster-traffic-ingress-controller

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.