[release-4.16] OCPBUGS-53237: Validation for API and Ingress VIPs when using user-managed load balancer #10048
Conversation
stephenfin
commented
Oct 30, 2025
stephenfin
commented
- Prevent default API and Ingress VIP generation for user-managed load balancers
- Add default load balancer if none is specified
- Add unit tests for OpenStack platform defaults
- Edit manifest test
- OCPBUGS-56079: apply fixes for yaml-lint errors
…balancers - Previously, when API and Ingress VIPs were not specified, default values were automatically generated for user-managed load balancers.This was unintended behavior. Now, if the user does not explicitly provide API and Ingress VIPs, a fatal error is thrown instead.
-If no load balancer is provided, a default OpenShift load balancer is now assigned automatically. This ensures proper handling and avoids misconfigurations.
Adds unit tests in platform_test.py to verify OpenStack platform defaults. Covers cases such as: - Assigning a default OpenShift-managed load balancer when none is specified - Handling user-managed load balancers with and without VIPs - Ensuring correct API and Ingress VIP assignments
- lb-default-stable: As a default load balancer is now being assigned when one is not provided this test needs to be updated to reflect that change - lb-unmanaged: I made changes to how the defaults are set. If the load balancer is user-managed VIPs will not automatically be assigned anymore. This change needs to be reflected in this test by adding a apiVIPs and ingressVIPs value to the install-config
Notes: there are other yaml-lint warnings but they've been there for a long time. This commit only focuses on the errors introduced during 4.19 cycle. Conflicts: .golangci.yaml NOTE(stephenfin): Changes to .golangci.yaml were removed because they don't apply here.
openshift-ci-robot
added
jira/severity-low
|
@stephenfin: This pull request references Jira Issue OCPBUGS-53237, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Stephen Finucane <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ci/prow/govet |
|
@stephenfin: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test govet |
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
openshift-ci
bot
added
the
backport-risk-assessed
|
@stephenfin: This pull request references Jira Issue OCPBUGS-53237, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@stephenfin: This pull request references Jira Issue OCPBUGS-53237, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@stephenfin: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 339c2bc
into
openshift:release-4.16
|
@stephenfin: Jira Issue Verification Checks: Jira Issue OCPBUGS-53237 Jira Issue OCPBUGS-53237 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.16.0-0.nightly-2025-11-08-150051 |
5 participants
