[release-4.16] OCPBUGS-53237: Validation for API and Ingress VIPs when using user-managed load balancer #9620
Conversation
…balancers - Previously, when API and Ingress VIPs were not specified, default values were automatically generated for user-managed load balancers.This was unintended behavior. Now, if the user does not explicitly provide API and Ingress VIPs, a fatal error is thrown instead.
-If no load balancer is provided, a default OpenShift load balancer is now assigned automatically. This ensures proper handling and avoids misconfigurations.
Adds unit tests in platform_test.py to verify OpenStack platform defaults. Covers cases such as: - Assigning a default OpenShift-managed load balancer when none is specified - Handling user-managed load balancers with and without VIPs - Ensuring correct API and Ingress VIP assignments
- lb-default-stable: As a default load balancer is now being assigned when one is not provided this test needs to be updated to reflect that change - lb-unmanaged: I made changes to how the defaults are set. If the load balancer is user-managed VIPs will not automatically be assigned anymore. This change needs to be reflected in this test by adding a apiVIPs and ingressVIPs value to the install-config
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-53140 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53237, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
openshift-ci-robot
added
the
jira/severity-low
|
@dkokkino: This pull request references Jira Issue OCPBUGS-53237, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/retest-required |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close in favour of #10048 |
|
@stephenfin: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53237. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6 participants
This is an automated cherry-pick of #9571
/assign openshift-ci-robot