Skip to content

Conversation

@dlom
Copy link
Contributor

@dlom dlom commented Nov 21, 2025

This PR also removes the installation of the libvirt-libs package. We'll see if that breaks anything! No it doesn't! I love konflux when it works

xref: HIVE-2984

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@dlom: This pull request references HIVE-2984 which is a valid jira issue.

In response to this:

This PR also removes the installation of the libvirt-libs package. We'll see if that breaks anything!

xref: HIVE-2984

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@dlom: This pull request references HIVE-2984 which is a valid jira issue.

In response to this:

This PR also removes the installation of the libvirt-libs package. We'll see if that breaks anything!

xref: HIVE-2984

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jstuever and suhanime November 21, 2025 20:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@dlom dlom force-pushed the HIVE-2984 branch 2 times, most recently from de90042 to 3d63662 Compare December 3, 2025 19:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2025
ARG DNF=dnf

# CVE-2023-6597
RUN ${DNF} upgrade -y python3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubi9-minimal (with microdnf) has no python3 dependency at all, this package is not present anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that might cause a problem with our makefile, which currently uses python on load to try to compute the semver. Time to resurrect HIVE-2862 / #2692 ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the final image, not the builder images

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2025

@dlom: This pull request references HIVE-2984 which is a valid jira issue.

In response to this:

This PR also removes the installation of the libvirt-libs package. We'll see if that breaks anything! No it doesn't! I love konflux when it works

xref: HIVE-2984

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom dlom force-pushed the HIVE-2984 branch 2 times, most recently from d668be4 to 7550caf Compare December 9, 2025 00:26
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

contentOrigin:
repofiles:
- ./redhat.repo
packages: [openssh-clients, libvirt-libs, tar, krb5-libs, krb5-devel] # this should be kept in sync with the Dockerfile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of krb5 included in ubi9-minimal is high enough that CVE-2023-39975 is not present

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e597cf4 into openshift:master Dec 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants