-
Notifications
You must be signed in to change notification settings - Fork 256
HIVE-2984: Switch BASE_IMAGE to ubi9-minimal #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dlom: This pull request references HIVE-2984 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@dlom: This pull request references HIVE-2984 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
de90042 to
3d63662
Compare
| ARG DNF=dnf | ||
|
|
||
| # CVE-2023-6597 | ||
| RUN ${DNF} upgrade -y python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi9-minimal (with microdnf) has no python3 dependency at all, this package is not present anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that might cause a problem with our makefile, which currently uses python on load to try to compute the semver. Time to resurrect HIVE-2862 / #2692 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for the final image, not the builder images
|
@dlom: This pull request references HIVE-2984 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d668be4 to
7550caf
Compare
2uasimojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| contentOrigin: | ||
| repofiles: | ||
| - ./redhat.repo | ||
| packages: [openssh-clients, libvirt-libs, tar, krb5-libs, krb5-devel] # this should be kept in sync with the Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of krb5 included in ubi9-minimal is high enough that CVE-2023-39975 is not present
|
@dlom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR also removes the installation of the libvirt-libs package. We'll see if that breaks anything!No it doesn't! I love konflux when it worksxref: HIVE-2984