Upgrade formik-pf to bring fix for submit issue

[rohitkrai03]

No description provided.

[codecov]

Codecov Report

Merging #272 (4862ca4) into main (2a65883) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   73.63%   73.63%           
=======================================
  Files         434      434           
  Lines        9175     9175           
  Branches     2455     2455           
=======================================
  Hits         6756     6756           
  Misses       2281     2281           
  Partials      138      138           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a65883...4862ca4. Read the comment docs.

[rottencandy]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rottencandy]

/retest

[rottencandy]

/retest

[rottencandy]

/retest

[rottencandy]

/retest

[rottencandy]

@rohitkrai03 looks like e2e tests are failing because triggering next button click doesn't work anymore, I replaced all .trigger('click') calls with .click({ force: true }) and it seems to work:

diff --git a/integration-tests/support/pages/AddComponentPage.ts b/integration-tests/support/pages/AddComponentPage.ts
@@ -34,7 +34,7 @@ export class AddComponentPage extends AbstractWizardPage {
   }
 
   clickNext() {
-    cy.get(addComponentPagePO.next).trigger('click');
+    cy.get(addComponentPagePO.next).click({ force: true });
   }
 
   loginByToken(username: string, token: string){
diff --git a/integration-tests/support/pages/ComponentsPage.ts b/integration-tests/support/pages/ComponentsPage.ts
@@ -76,7 +76,7 @@ export class ComponentPage extends AbstractWizardPage {
   }
 
   createApplication() {
-    cy.get(ComponentsPagePO.create).trigger('click');
+    cy.get(ComponentsPagePO.create).click({ force: true });
     cy.get(ComponentsPagePO.create).should('be.disabled');
     Common.waitForLoad();
   }
diff --git a/integration-tests/support/pages/CreateApplicationPage.ts b/integration-tests/support/pages/CreateApplicationPage.ts
@@ -31,6 +31,6 @@ export class CreateApplicationPage extends AbstractWizardPage {
   }
 
   clickNext() {
-    cy.get(createApplicationPagePO.next).trigger('click');
+    cy.get(createApplicationPagePO.next).click({ force: true });
   }
 }
diff --git a/integration-tests/support/pages/hacbs/AddIntegrationTestPage.ts b/integration-tests/support/pages/hacbs/AddIntegrationTestPage.ts
@@ -14,7 +14,7 @@ export class AddIntegrationTestPage {
         cy.get(addIntegrationTestStepPO.optionalreleaseCheckbox).click();
     }
     clickNext() {
-        cy.get(addIntegrationTestStepPO.next).trigger('click');
+        cy.get(addIntegrationTestStepPO.next).click({ force: true });
     }
     clickAdd() {
         cy.get(addIntegrationTestStepPO.add).click();
diff --git a/integration-tests/support/pages/hacbs/CreateBuildPage.ts b/integration-tests/support/pages/hacbs/CreateBuildPage.ts
@@ -2,6 +2,6 @@ import { createBuildStepPO } from '../../pageObjects/hacbs-po';
 
 export class CreateBuildPage {
     clickNext() {
-        cy.get(createBuildStepPO.next).trigger('click');
+        cy.get(createBuildStepPO.next).click({ force: true });
     }
 }
diff --git a/integration-tests/utils/Applications.ts b/integration-tests/utils/Applications.ts
@@ -23,6 +23,7 @@ export class Applications {
     cy.testA11y(`${pageTitles.createApp} page`);
     createApplicationPage.setApplicationName(name);
     createApplicationPage.clickNext();
+    createApplicationPage.clickNext();
     cy.testA11y(`Select source form`);
   }
 }

[openshift-ci]

New changes are detected. LGTM label has been removed.

[rottencandy]

@rohitkrai03 sorry I missed the hacbs pages, can you try these changes too

diff --git a/integration-tests/support/pages/ComponentsPage.ts b/integration-tests/support/pages/ComponentsPage.ts
index 1768341..1eb3416 100644
@@ -76,6 +76,7 @@ export class ComponentPage extends AbstractWizardPage {
   }
 
   createApplication() {
+    cy.get(ComponentsPagePO.create).click({ force: true });
     cy.get(ComponentsPagePO.create).click({ force: true });
     cy.get(ComponentsPagePO.create).should('be.disabled');
     Common.waitForLoad();
diff --git a/integration-tests/utils/HACBSApplications.ts b/integration-tests/utils/HACBSApplications.ts
index d0ce90a..41523ff 100644
@@ -106,6 +106,11 @@ export function addIntegrationTestStep(displayName: string, optionalForRelease:
     }
 
     cy.get('body').then(body => {
-        (body.find('button[type="submit"]').length > 0)? addIntegrationTestPage.clickNext() : addIntegrationTestPage.clickAdd();
+        if (body.find('button[type="submit"]').length > 0) {
+          addIntegrationTestPage.clickNext();
+          addIntegrationTestPage.clickNext();
+        } else {
+          addIntegrationTestPage.clickAdd()
+        };
     });
 }

[openshift-ci]

@rohitkrai03: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rottencandy]

/retest

[rottencandy]

/retest

[openshift-merge-robot]

@rohitkrai03: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

Closing this PR for now. Will raise another one once we have the e2e tests fixed. This PR require updates to e2e tests and since they are already broken due to different reasons its hard to debug the issue.