Skip to content

Commit

Permalink
Upgrade formik-pf to bring fix for submit issue
Browse files Browse the repository at this point in the history
  • Loading branch information
rohitkrai03 committed Dec 12, 2022
1 parent 5a13d22 commit a8ff39e
Show file tree
Hide file tree
Showing 8 changed files with 39 additions and 37 deletions.
6 changes: 3 additions & 3 deletions integration-tests/support/pages/AddComponentPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ export class AddComponentPage extends AbstractWizardPage {
}

clickNext() {
cy.get(addComponentPagePO.next).trigger('click');
cy.get(addComponentPagePO.next).click({ force: true });
}

loginByToken(username: string, token: string){
cy.contains('button', addComponentPagePO.useTokenButton, {timeout : 120000}).click();
loginByToken(username: string, token: string) {
cy.contains('button', addComponentPagePO.useTokenButton, { timeout: 120000 }).click();
cy.get(addComponentPagePO.username).type(username);
cy.get(addComponentPagePO.token).type(token, { log: false });
cy.wait(2000);
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/support/pages/ComponentsPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class ComponentPage extends AbstractWizardPage {
}

createApplication() {
cy.get(ComponentsPagePO.create).trigger('click');
cy.get(ComponentsPagePO.create).click({ force: true });
cy.get(ComponentsPagePO.create).should('be.disabled');
Common.waitForLoad();
}
Expand Down
9 changes: 5 additions & 4 deletions integration-tests/support/pages/CreateApplicationPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ export class CreateApplicationPage extends AbstractWizardPage {
cy.get(createApplicationPagePO.applicationName).clear();
}

clickCreateApplication() {
cy.get('body').then(body => {
clickCreateApplication() {
cy.get('body').then((body) => {
if (body.find("h4:contains('No applications')").length > 0) {
cy.get('.pf-c-empty-state__content')
.contains(createApplicationPagePO.createApplication).click({ force: true });
.contains(createApplicationPagePO.createApplication)
.click({ force: true });
} else {
cy.contains(createApplicationPagePO.createApplication).click({ force: true });
}
Expand All @@ -31,6 +32,6 @@ export class CreateApplicationPage extends AbstractWizardPage {
}

clickNext() {
cy.get(createApplicationPagePO.next).trigger('click');
cy.get(createApplicationPagePO.next).click({ force: true });
}
}
36 changes: 18 additions & 18 deletions integration-tests/support/pages/hacbs/AddIntegrationTestPage.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import { addIntegrationTestStepPO } from '../../pageObjects/hacbs-po';

export class AddIntegrationTestPage {
enterDisplayName(displayName: string) {
cy.get(addIntegrationTestStepPO.displayNameInput).clear().type(displayName);
}
enterContainerImage(containerImage: string) {
cy.get(addIntegrationTestStepPO.containerImageInput).clear().type(containerImage);
}
enterPipelineName(pipelineName: string) {
cy.get(addIntegrationTestStepPO.pipelineNameInput).clear().type(pipelineName);
}
markOptionalForRelease() {
cy.get(addIntegrationTestStepPO.optionalreleaseCheckbox).click();
}
clickNext() {
cy.get(addIntegrationTestStepPO.next).trigger('click');
}
clickAdd() {
cy.get(addIntegrationTestStepPO.add).click();
}
enterDisplayName(displayName: string) {
cy.get(addIntegrationTestStepPO.displayNameInput).clear().type(displayName);
}
enterContainerImage(containerImage: string) {
cy.get(addIntegrationTestStepPO.containerImageInput).clear().type(containerImage);
}
enterPipelineName(pipelineName: string) {
cy.get(addIntegrationTestStepPO.pipelineNameInput).clear().type(pipelineName);
}
markOptionalForRelease() {
cy.get(addIntegrationTestStepPO.optionalreleaseCheckbox).click();
}
clickNext() {
cy.get(addIntegrationTestStepPO.next).click({ force: true });
}
clickAdd() {
cy.get(addIntegrationTestStepPO.add).click();
}
}
6 changes: 3 additions & 3 deletions integration-tests/support/pages/hacbs/CreateBuildPage.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createBuildStepPO } from '../../pageObjects/hacbs-po';

export class CreateBuildPage {
clickNext() {
cy.get(createBuildStepPO.next).trigger('click');
}
clickNext() {
cy.get(createBuildStepPO.next).click({ force: true });
}
}
1 change: 1 addition & 0 deletions integration-tests/utils/Applications.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export class Applications {
cy.testA11y(`${pageTitles.createApp} page`);
createApplicationPage.setApplicationName(name);
createApplicationPage.clickNext();
createApplicationPage.clickNext();
cy.testA11y(`Select source form`);
}
}
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"dayjs": "^1.10.8",
"file-saver": "1.3.x",
"formik": "^2.2.9",
"formik-pf": "^0.0.1-alpha9",
"formik-pf": "^0.0.1-alpha10",
"history": "5.3.0",
"i18next": "^19.8.3",
"js-base64": "^2.5.1",
Expand Down

0 comments on commit a8ff39e

Please sign in to comment.