Skip to content

Conversation

@dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Dec 2, 2025

Tests are skipped because of a missing VAC during the testing phase. VAC copied from AWS EBS driver.

External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should create a volume with VAC

Reason: skip [k8s.io/[email protected]/test/e2e/storage/external/external.go:440]: Driver "ebs.csi.aws.com" has no configured VolumeAttributesClass - skipping

cc @radeore

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request explicitly references no jira issue.

Details

In response to this:

Tests are skipped because of a missing VAC during the testing phase. VAC copied from AWS EBS driver.

External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should create a volume with VAC

Reason: skip [k8s.io/[email protected]/test/e2e/storage/external/external.go:440]: Driver "ebs.csi.aws.com" has no configured VolumeAttributesClass - skipping

cc @radeore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from RomanBednar December 2, 2025 21:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@openshift-ci openshift-ci bot requested a review from tsmetana December 2, 2025 21:32
@Phaow
Copy link
Contributor

Phaow commented Dec 4, 2025

/retest-required

@duanwei33
Copy link
Contributor

We need to copy this volumeattributesclass.yaml for usage like:
https://github.com/openshift/release/blob/master/ci-operator/step-registry/storage/conf/csi-aws-ebs/storage-conf-csi-aws-ebs-commands.sh#L8-L14

@radeore
Copy link

radeore commented Dec 8, 2025

/retest-required

1 similar comment
@Phaow
Copy link
Contributor

Phaow commented Dec 11, 2025

/retest-required

@Phaow
Copy link
Contributor

Phaow commented Dec 11, 2025

Current test result looks good enough, we expect the [Flaky] label tests should be excluded for openshift/csi test suite by default, this should be a bug of OTE, I fixed it in openshift/origin#30597.

@radeore
Copy link

radeore commented Dec 15, 2025

/retitle STOR-2543: add VAC manifest for tests in AWS EBS

@openshift-ci openshift-ci bot changed the title NO-JIRA: add VAC for tests [STOR-2543](https://issues.redhat.com/browse/STOR-2543): add VAC manifest for tests in AWS EBS Dec 15, 2025
@radeore
Copy link

radeore commented Dec 15, 2025

/retitle STOR-2543: add VAC manifest for tests in AWS EBS

@openshift-ci openshift-ci bot changed the title [STOR-2543](https://issues.redhat.com/browse/STOR-2543): add VAC manifest for tests in AWS EBS STOR-2543: add VAC manifest for tests in AWS EBS Dec 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2025

@dfajmon: This pull request references STOR-2543 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Tests are skipped because of a missing VAC during the testing phase. VAC copied from AWS EBS driver.

External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should create a volume with VAC

Reason: skip [k8s.io/[email protected]/test/e2e/storage/external/external.go:440]: Driver "ebs.csi.aws.com" has no configured VolumeAttributesClass - skipping

cc @radeore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Dec 16, 2025

/test e2e-aws-csi

@Phaow
Copy link
Contributor

Phaow commented Dec 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@jsafrane
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 17, 2025
@radeore
Copy link

radeore commented Dec 17, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 17, 2025
@openshift-ci-robot
Copy link

@radeore: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c8fd83 and 2 for PR HEAD 998f19e in total

@radeore
Copy link

radeore commented Dec 17, 2025

/retest-required

1 similar comment
@dfajmon
Copy link
Contributor Author

dfajmon commented Dec 18, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4462c7a into openshift:main Dec 18, 2025
19 checks passed
@radeore
Copy link

radeore commented Dec 19, 2025

/cherry-pick release-4.21

@openshift-cherrypick-robot

@radeore: new pull request created: #485

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants