-
Notifications
You must be signed in to change notification settings - Fork 2k
STOR-2543: Add volumeattributesclass.yaml support for AWS EBS CSI VolumeAttributesClass tests #72189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@radeore: This pull request references STOR-2543 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
A total of 221 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@radeore: This pull request references STOR-2543 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@radeore: This pull request references STOR-2543 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi pull-ci-openshift-csi-operator-main-e2e-aws-csi |
|
@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-release-4.20-e2e-aws-csi |
|
@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@radeore: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm rehearse jobs fail because the file is missing but we are adding it in this PR openshift/csi-operator#475 |
| cat ${SHARED_DIR}/${TEST_OCP_CSI_DRIVER_MANIFEST} | ||
| fi | ||
| echo "Copying ${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST} to ${SHARED_DIR}/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST}" | ||
| cp test/e2e/aws-ebs/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST} ${SHARED_DIR}/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST specified a relative path in test/e2e/aws-ebs or is absolute path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably fine though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a relative path in csi-operator/test/e2e/aws-ebs
|
/approve |
|
/pj-rehearse-ack |
|
@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon, gnufied, radeore The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gnufied: job(s): /pj-rehearse-ack either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse-ack |
|
@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@radeore: job(s): /pj-rehearse-ack either don't exist or were not found to be affected, and cannot be rehearsed |
|
/rehearsals-ack |
1 similar comment
|
/rehearsals-ack |
|
/pj-rehearsals-ack |
|
/pj-rehearse ack |
|
@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
44ec634
into
openshift:master
Add volumeattributesclass.yaml support for AWS EBS CSI tests
This change adds support for VolumeAttributesClass tests by:
csi-operatorrepository to${SHARED_DIR}so it's available for openshift-testsThis should resolve the VAC test failures in PR
cc. @dfajmon