Skip to content

Conversation

@radeore
Copy link
Contributor

@radeore radeore commented Dec 4, 2025

Add volumeattributesclass.yaml support for AWS EBS CSI tests

This change adds support for VolumeAttributesClass tests by:

  • Copying volumeattributesclass.yaml from csi-operator repository to ${SHARED_DIR} so it's available for openshift-tests
  • Adding TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST environment variable with default value

This should resolve the VAC test failures in PR

cc. @dfajmon

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2025

@radeore: This pull request references STOR-2543 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add volumeattributesclass.yaml support for AWS EBS CSI tests

This change adds support for VolumeAttributesClass tests by:

  • Copying volumeattributesclass.yaml from csi-operator repository to ${SHARED_DIR} so it's available for openshift-tests
  • Adding TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST environment variable with default value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied December 4, 2025 22:06
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@radeore: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-external-attacher-master-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.22-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.21-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.20-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.19-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.18-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.17-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.16-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.15-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.14-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.13-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.12-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.11-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.10-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.9-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.8-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.7-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-csi-external-attacher-release-4.6-e2e-aws-csi openshift/csi-external-attacher presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.14-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.13-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.12-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.11-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.10-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.9-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.8-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed

A total of 221 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2025

@radeore: This pull request references STOR-2543 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add volumeattributesclass.yaml support for AWS EBS CSI tests

This change adds support for VolumeAttributesClass tests by:

  • Copying volumeattributesclass.yaml from csi-operator repository to ${SHARED_DIR} so it's available for openshift-tests
  • Adding TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST environment variable with default value

This should resolve the VAC test failures in PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2025

@radeore: This pull request references STOR-2543 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add volumeattributesclass.yaml support for AWS EBS CSI tests

This change adds support for VolumeAttributesClass tests by:

  • Copying volumeattributesclass.yaml from csi-operator repository to ${SHARED_DIR} so it's available for openshift-tests
  • Adding TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST environment variable with default value

This should resolve the VAC test failures in PR

cc. @dfajmon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@radeore
Copy link
Contributor Author

radeore commented Dec 4, 2025

/pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi pull-ci-openshift-csi-operator-main-e2e-aws-csi

@openshift-ci-robot
Copy link
Contributor

@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@radeore
Copy link
Contributor Author

radeore commented Dec 4, 2025

/pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-release-4.20-e2e-aws-csi

@openshift-ci-robot
Copy link
Contributor

@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

@radeore: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/aws-ebs-csi-driver/master/e2e-aws-csi fbe0a5a link unknown /pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi
ci/rehearse/openshift/aws-ebs-csi-driver/release-4.20/e2e-aws-csi fbe0a5a link unknown /pj-rehearse pull-ci-openshift-aws-ebs-csi-driver-release-4.20-e2e-aws-csi
ci/rehearse/openshift/csi-operator/main/e2e-aws-csi fbe0a5a link unknown /pj-rehearse pull-ci-openshift-csi-operator-main-e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon
Copy link
Contributor

dfajmon commented Dec 5, 2025

/lgtm

rehearse jobs fail because the file is missing but we are adding it in this PR openshift/csi-operator#475
which also needs this PR to register the file

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
cat ${SHARED_DIR}/${TEST_OCP_CSI_DRIVER_MANIFEST}
fi
echo "Copying ${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST} to ${SHARED_DIR}/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST}"
cp test/e2e/aws-ebs/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST} ${SHARED_DIR}/${TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is TEST_VOLUME_ATTRIBUTES_CLASS_MANIFEST specified a relative path in test/e2e/aws-ebs or is absolute path?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably fine though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a relative path in csi-operator/test/e2e/aws-ebs

@gnufied
Copy link
Member

gnufied commented Dec 8, 2025

/approve

@gnufied
Copy link
Member

gnufied commented Dec 8, 2025

/pj-rehearse-ack

@openshift-ci-robot
Copy link
Contributor

@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, gnufied, radeore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@openshift-ci-robot
Copy link
Contributor

@gnufied: job(s): /pj-rehearse-ack either don't exist or were not found to be affected, and cannot be rehearsed

@radeore
Copy link
Contributor Author

radeore commented Dec 8, 2025

/pj-rehearse-ack

@openshift-ci-robot
Copy link
Contributor

@radeore: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@radeore: job(s): /pj-rehearse-ack either don't exist or were not found to be affected, and cannot be rehearsed

@radeore
Copy link
Contributor Author

radeore commented Dec 8, 2025

/rehearsals-ack

1 similar comment
@radeore
Copy link
Contributor Author

radeore commented Dec 8, 2025

/rehearsals-ack

@radeore
Copy link
Contributor Author

radeore commented Dec 8, 2025

/pj-rehearsals-ack

@gnufied
Copy link
Member

gnufied commented Dec 8, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 44ec634 into openshift:master Dec 8, 2025
10 of 13 checks passed
dfrazzette pushed a commit to dfrazzette/release that referenced this pull request Dec 9, 2025
eifrach pushed a commit to eifrach/release that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants