Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #17

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Refactor #17

merged 4 commits into from
Sep 20, 2024

Conversation

sepandhaghighi
Copy link
Member

@sepandhaghighi sepandhaghighi commented Sep 17, 2024 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • opr_param.py --> params.py
  • opr_obj.py --> primer.py
  • opr_error --> errors.py
  • Minor edits in RELEASE.md
  • OPRBaseError added to __init__.py

Any other comments?

@sepandhaghighi sepandhaghighi added this to the opr v0.1 milestone Sep 17, 2024
@sepandhaghighi sepandhaghighi self-assigned this Sep 17, 2024
@AHReccese
Copy link
Member

There isn't any need to update the CHANGELOG.md file in this PR right?
@sepandhaghighi

@sepandhaghighi
Copy link
Member Author

There isn't any need to update the CHANGELOG.md file in this PR right? @sepandhaghighi

No.
As these refactorings are before the version 0.1 release, there is no need to add them to CHANGELOG.md.

@AHReccese AHReccese merged commit 33432c2 into dev Sep 20, 2024
42 checks passed
@AHReccese AHReccese deleted the refactor branch September 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHReccese AHReccese AHReccese approved these changes

Assignees

@sepandhaghighi sepandhaghighi

Labels
minor refactoring
Projects
None yet
Milestone
opr v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sepandhaghighi @AHReccese