-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK-306: Integrated Micro Frontend Tooling Setup in OpenMRS SDK - Reactoring #224
Conversation
@wikumChamith can you look at the build failures? |
@dkayiwa I think they got fixed with this. Is there a way to re-run checks without pushing again?? |
@dkayiwa I merged master into this. |
@@ -779,7 +779,7 @@ private Map<String, String> getDistroVersionsOptionsMap(Set<String> versions, Ve | |||
private Map<String, String> getO3VersionsOptionsMap(VersionsHelper versionsHelper, | |||
String optionTemplate, String artifactTemplate) { | |||
Map<String, String> optionsMap = new LinkedHashMap<>(); | |||
Artifact artifact = new Artifact("referenceapplication-distro", "3.0.0-SNAPSHOT", "org.openmrs.distro", "zip"); | |||
Artifact artifact = new Artifact("referenceapplication-distro", null, "org.openmrs.distro", "zip"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember suggesting passing NULL for the version parameter and you said it was not allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkayiwa apologies for the confusion. When evaluating with the debugger I encountered an exception when using null. So I decided not to use null. Upon further investigation, I realized that even though an exception gets thrown, the code was still able to fetch the versions list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid the exception being thrown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkayiwa I am sorry, I have made a mistake. I accidentally ran
mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.6.0-SNAPSHOT:setup
instead of mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.7.0-SNAPSHOT:setup
when testing new code changes.
We can't still use null
. If we pass null we get the following error.
[ERROR] Failed to execute goal org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.7.0-SNAPSHOT:setup (default-cli) on project openmrs-sdk: Failed to setup server: For artifact {org.openmrs.distro:referenceapplication-distro:null:}: The version cannot be empty.
I am changing the argument to "version".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkayiwa I am really sorry, I have made a mistake. I accidentally ran
mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.6.0-SNAPSHOT:setup
instead of mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.7.0-SNAPSHOT:setup
when testing new code changes.
We can't still use null
. If we pass null we get the following error.
[ERROR] Failed to execute goal org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.7.0-SNAPSHOT:setup (default-cli) on project openmrs-sdk: Failed to setup server: For artifact {org.openmrs.distro:referenceapplication-distro:null:}: The version cannot be empty.
I am changing the parameter to "version"
.
@wikumChamith can we also let someone choose the version of the openmrs assemble and build tools to use? The default can remain
|
@dkayiwa should these get included in the distro.properties? |
Can i also pass it in as a command line argument? |
Then we should add new maven parameters for them. @dkayiwa could you create a new ticket for this with more details?? We can discuss this there. |
Yes you can create a ticket. |
@dkayiwa I created a ticket: https://issues.openmrs.org/browse/SDK-312 |
This is to address issues with a41bab6
Jira ticket: https://issues.openmrs.org/browse/SDK-306