Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-306: Integrated Micro Frontend Tooling Setup in OpenMRS SDK - Refactoring #221

Closed
wants to merge 0 commits into from
Closed

SDK-306: Integrated Micro Frontend Tooling Setup in OpenMRS SDK - Refactoring #221

wants to merge 0 commits into from

Conversation

wikumChamith
Copy link
Contributor

@wikumChamith wikumChamith commented Jun 13, 2023 •
edited
Loading

Rename Setup.setConfig to Setup.createConfigurationFolder and Setup.downloadConfig to Setup.downloadConfiguration

Jira ticket: https://issues.openmrs.org/browse/SDK-306

wikumChamith referenced this pull request Jun 13, 2023
@wikumChamith
SDK-306: Integrated Micro Frontend Tooling Setup in OpenMRS SDK (#220)
a41bab6 
This allows developers to deploy distro.properties files with "config.referenceapplication-config=version".
@dkayiwa
Copy link
Member

dkayiwa commented Jun 14, 2023

@wikumChamith have you tried to run the mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.6.0-SNAPSHOT:setup command outside of the sdk source folder?

@wikumChamith
Copy link
Contributor Author

wikumChamith commented Jun 16, 2023 •
edited
Loading

@wikumChamith have you tried to run the mvn org.openmrs.maven.plugins:openmrs-sdk-maven-plugin:4.6.0-SNAPSHOT:setup command outside of the sdk source folder?

@dkayiwa I just tried this. It is not showing all the server versions.

[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- openmrs-sdk-maven-plugin:4.6.0-SNAPSHOT:setup (default-cli) @ standalone-pom ---

Setting up a new server...

Specify server id (-DserverId) (default: 'server15'): 

You can setup the following servers:
1) 2.x Distribution
2) Platform
3) 03 Distribution

Which one do you choose? [1/2/3]: 3

You can deploy the following versions of O3:
1) Reference Application 3.0.0-SNAPSHOT
2) Other...

Looks like this is running an older version of my code, Is there a way to update this?

@wikumChamith
Copy link
Contributor Author

@dkayiwa Is it possible to run this from anywhere?? I thought we have to make a release for this.

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

@wikumChamith i made a release for 4.6.0
Can you try it out?

@wikumChamith
Copy link
Contributor Author

@wikumChamith i made a release for 4.6.0 Can you try it out?

Just checked it, Still got the error. Any idea what is causing it??

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

Which error?

@wikumChamith
Copy link
Contributor Author

wikumChamith commented Jun 16, 2023 •
edited
Loading

Which error?

SDK only shows Reference Application 3.0.0-SNAPSHOT. I am getting this error after selecting it.

Unable to find/resolve artifact. Failure to find org.openmrs.module:initializer-omod:jar:2.5.0 in https://mavenrepo.openmrs.org/public was cached in the local repository, resolution will not be reattempted until the update interval of openmrs-repo has elapsed or updates are forced

@wikumChamith
Copy link
Contributor Author

@ibacher I made the change you requested.

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

SDK only shows Reference Application 3.0.0-SNAPSHOT.

Can you add this to your settings.xml file? https://pastebin.com/jMrC2XJQ

@wikumChamith
Copy link
Contributor Author

SDK only shows Reference Application 3.0.0-SNAPSHOT.

Can you add this to your settings.xml file? https://pastebin.com/jMrC2XJQ

Now It is working fine. Will other users get the same error??

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

Will other users get the same error??

Yes they will get the same error for as long as they do not have that repository in their settings.xml file

@wikumChamith
Copy link
Contributor Author

Will other users get the same error??

Yes they will get the same error for as long as they do not have that repository in their settings.xml file

What should we do about it??

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

What should we do about it??

Update the documentation to reflect it.

@wikumChamith
Copy link
Contributor Author

What should we do about it??

Update the documentation to reflect it.

Does this impact only users who already have the SDK, or does it also apply to new users?

@dkayiwa
Copy link
Member

dkayiwa commented Jun 16, 2023

Does this impact only users who already have the SDK, or does it also apply to new users?

It applies to whoever does not have that repository in their settings.xml file

@wikumChamith
Copy link
Contributor Author

What should we do about it??

Update the documentation to reflect it.

@dkayiwa I updated the documentation. https://wiki.openmrs.org/pages/viewpage.action?pageId=224527013

@wikumChamith
Copy link
Contributor Author

@dkayiwa, @ibacher is everything ok with this??

@dkayiwa
Copy link
Member

dkayiwa commented Jun 19, 2023

@wikumChamith can you create a talk post and ask frontend devs to try set up an O3 backend server using the SDK?

@dkayiwa
Copy link
Member

dkayiwa commented Jun 19, 2023

I updated the documentation. https://wiki.openmrs.org/pages/viewpage.action?pageId=224527013

Awesome! 👍

@wikumChamith
Copy link
Contributor Author

@wikumChamith can you create a talk post and ask frontend devs to try set up an O3 backend server using the SDK?

@dkayiwa I created a talk post: https://talk.openmrs.org/t/deploying-o3-with-the-sdk/39925

ibacher
ibacher reviewed Jun 21, 2023
View reviewed changes
sdk-commons/src/main/java/org/openmrs/maven/plugins/utility/DefaultWizard.java Outdated
@@ -779,7 +779,7 @@ private Map<String, String> getDistroVersionsOptionsMap(Set<String> versions, Ve
private Map<String, String> getO3VersionsOptionsMap(VersionsHelper versionsHelper,
String optionTemplate, String artifactTemplate) {
Map<String, String> optionsMap = new LinkedHashMap<>();
Artifact artifact = new Artifact("referenceapplication-distro", "3.0.0-SNAPSHOT", "org.openmrs.distro", "zip");
Artifact artifact = new Artifact("referenceapplication-distro", "version", "org.openmrs.distro", "zip");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with the string "version"? I would've thought this should be null or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher I made the change.

@wikumChamith wikumChamith deleted the SDK-306 branch June 22, 2023 15:28
@wikumChamith
Copy link
Contributor Author

new PR: #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wikumChamith @dkayiwa @ibacher