8368848: JShell's code completion not always working for multi-snippet inputs

[lahodaj]

Having a JShell input like:

jshell> String s() { return "";} s(). 

the code completion is not working for it. The reason is that the input is two snippets, but the code completion will interpret it as only one snippet, and a method declaration and method invocation cannot coexist inside one snippet (as one is a declaration that must appear outside of a method, and the invocation must be inside a method body or field initializer).

The proposal herein is for the JShell's code completion to split the input into snippets, and create a wrapper/compilation unit based on all the snippets.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368848: JShell's code completion not always working for multi-snippet inputs (Task - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27552/head:pull/27552
$ git checkout pull/27552

Update a local copy of the PR:
$ git checkout pull/27552
$ git pull https://git.openjdk.org/jdk.git pull/27552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27552

View PR using the GUI difftool:
$ git pr show -t 27552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27552.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368848: JShell's code completion not always working for multi-snippet inputs

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• 6b4b102: 8368809: JFR: Remove events from testSettingConfiguration in TestActiveSettingEvent
• 8cc54ec: 8368563: JFR: Improve jfr query help text
• 07ea907: 8361606: ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a
• ... and 43 more: https://git.openjdk.org/jdk/compare/7bfdb0120752d01da96c19e8037a6e909847d63c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (34437a79)

[asotona]

Looks good to me.