-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8366691: JShell should support a more convenient completion #27049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/27552
Are you sure you want to change the base?
Conversation
…and enum constants.
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8366691
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@lahodaj this pull request can not be integrated into git checkout JDK-8366691
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Progress
Error
Integration blocker
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27049/head:pull/27049
$ git checkout pull/27049
Update a local copy of the PR:
$ git checkout pull/27049
$ git pull https://git.openjdk.org/jdk.git pull/27049/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27049
View PR using the GUI difftool:
$ git pr show -t 27049
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27049.diff