Skip to content

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 2, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8367252 to be approved

Error

 ⚠️ The pull request body must not be empty.

Integration blocker

 ⚠️ Dependency #27552 must be integrated first

Issues

  • JDK-8366691: JShell should support a more convenient completion (Enhancement - P4)
  • JDK-8367252: JShell should support a more convenient completion (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27049/head:pull/27049
$ git checkout pull/27049

Update a local copy of the PR:
$ git checkout pull/27049
$ git pull https://git.openjdk.org/jdk.git pull/27049/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27049

View PR using the GUI difftool:
$ git pr show -t 27049

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27049.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into pr/22840 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

⚠️ @lahodaj This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/22840 to master September 11, 2025 10:49
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8366691
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@lahodaj this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8366691
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 11, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Sep 12, 2025
@lahodaj lahodaj changed the base branch from master to pr/27552 October 1, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] csr Pull request needs approved CSR before integration
Development

Successfully merging this pull request may close these issues.

1 participant