[oppo] rollforward a few review changes from sister bindings and fix a title #8335
Conversation
update fork
update fork
update fork
update fork
update fork
update fork
update fork
update fork
Update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
| @@ -42,7 +42,7 @@ | |||
| * @param connector the object that should handle the received message | |||
| */ | |||
| public OppoReaderThread(OppoConnector connector, String uid) { | |||
| super(OppoBindingConstants.BINDING_ID + "-" + uid); | |||
| super("OH-binding-" + OppoBindingConstants.BINDING_ID + "-" + uid); | |||
There was a problem hiding this comment.
You do not need the binding id as already included in uid (thing uid).
There was a problem hiding this comment.
The variable was named poorly so I corrected it. The idea was to help identify the particular connection (IP+ port or serial port name) in the case of multiple instances of the binding being used.
There was a problem hiding this comment.
Look at #8216, you are not following the new thread naming convention. You have to replace binding id by thing uid. Then having the serial port name as custom part in the name is ok.
There was a problem hiding this comment.
ok, it should be fixed now.
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
|
You used the thing type uid rather than the thing uid, |
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
…a title (openhab#8335) * Rollforward a few review changes * fix thread naming convention Signed-off-by: Michael Lobstein <[email protected]>
No description provided.