Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oppo] fix thread naming convention per comments in #8335 #8347

Merged
merged 11 commits into from
Aug 26, 2020
Merged

[oppo] fix thread naming convention per comments in #8335 #8347

merged 11 commits into from
Aug 26, 2020

Conversation

mlobstein
Copy link
Contributor

No description provided.

@mlobstein
Copy link
Contributor Author

@lolodomo changes done per your comments in #8335
@Hilbrand for awareness

@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

lolodomo
lolodomo approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hilbrand
Hilbrand approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Hilbrand Hilbrand merged commit aea27b4 into openhab:2.5.x Aug 26, 2020
@mlobstein mlobstein deleted the oppo_threadname branch August 26, 2020 19:58
@cpmeister cpmeister added this to the 2.5.9 milestone Aug 27, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mlobstein @andrewfg
[oppo] Fix thread naming convention (openhab#8347)
50b494b 
Signed-off-by: Michael Lobstein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mlobstein @andrewfg
[oppo] Fix thread naming convention (openhab#8347)
56ec98c 
Signed-off-by: Michael Lobstein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mlobstein @andrewfg
[oppo] Fix thread naming convention (openhab#8347)
c589758 
Signed-off-by: Michael Lobstein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mlobstein @andrewfg
[oppo] Fix thread naming convention (openhab#8347)
3633f9c 
Signed-off-by: Michael Lobstein <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@mlobstein @DaanMeijer
[oppo] Fix thread naming convention (openhab#8347)
3287085 
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@mlobstein @CSchlipp
[oppo] Fix thread naming convention (openhab#8347)
4799879 
Signed-off-by: Michael Lobstein <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@mlobstein @markus7017
[oppo] Fix thread naming convention (openhab#8347)
df7f84e 
Signed-off-by: Michael Lobstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
5 participants
@mlobstein @TravisBuddy @Hilbrand @lolodomo @cpmeister