Repository navigation
Add clipboard, pop-up modes and label display options - #25
Conversation
Copy, cut and paste features (also as GeoJSON on the system clipboard), paste them as a new layer, and copy a layer's data path, from the Map and Edit tabs. Pop-ups identify the topmost layer, every visible layer, selectable layers, the layer selected in Contents, or nothing. Labels gain a scale and viewing-distance range, ten placements, and map-wide Lock, Pause and View Unplaced switches; Convert turns a layer's labels into an annotation layer.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if clear { | ||
| l.labels.min_scale = None; | ||
| l.labels.max_scale = None; | ||
| l.labels.closest = None; |
There was a problem hiding this comment.
labels.scaleRange with clear: true also resets the distance limits (closest/farthest), and labels.distanceRange doesn't reset the scale limits. The "Clear Limits" button is probably meant to clear both, but a script that calls labels.scaleRange {clear:true} to clear only the scale range will silently lose the distance range. Consider making the two commands clear only their own limits and having the UI button call both. Confidence: medium.
Code reviewI read the new clipboard and label commands in full. For the pop-up stepping change in Bugs
Security
Performance
Quality
CLAUDE.md (AGENTS.md)
|
📖 Docs preview
|
1 participant
Summary
Adds 25 ribbon features (coverage 69 → 94 of 316).
identifyalso takes amodeparameter.TEXTfield).edit.copy,edit.cut,edit.paste,edit.pasteSpecial,layer.copyPath,map.popupMode,labels.lock,labels.pause,labels.viewUnplaced,labels.convert,labels.scaleRange,labels.distanceRange,labels.placement.Testing
cargo xtask cipasses; the wasm build passes.hostile_params_never_paniccovers the new commands.us_regions.geojsonandus_cities.geojson) throughrustgis-cli: Visible Layers identify returned both layers, Copy Path returned the file path, copying the five cities over 5 million and Paste Special made a new layer, and Convert made a four-label region annotation layer. The exported map showed right-placed labels with unplaced ones in red.