Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Chinese serving size #1618

Open
aleene opened this issue Jan 13, 2019 · 4 comments
Open

Support Chinese serving size #1618

aleene opened this issue Jan 13, 2019 · 4 comments
Labels
China portions

Comments

@aleene
Copy link
Contributor

aleene commented Jan 13, 2019 •
edited by teolemon
Loading

Summary

  • If you enter a serving in chinese, i.e. 38公克, it will not be recognized. And no values per serving are calculated.

Steps to reproduce

Expected behavior

  • Probably recognise "公克" as "g" and all will be well.

Observed behavior

  • nothing happened.

Part of
@hangy hangy mentioned this issue Feb 16, 2019
Merged
@hangy
Copy link
Member

hangy commented Feb 16, 2019

I added some Chinese units in 3f4be29. However, the source that I found, claims that "克" is "g", so I'm not quite sure what's actually correct. Maybe a native speaker could weigh in. 🙂

@aleene
Copy link
Contributor Author

aleene commented Feb 17, 2019 •
edited
Loading

You are correct. They seem to add 公, to indicate metric gram. Anyway they are both found on packages. Wikidata notes it as an alternative.

@aleene
Copy link
Contributor Author

aleene commented Feb 17, 2019

Install google translate on your phone and you can also add chinese products to off.

@aleene
Copy link
Contributor Author

aleene commented Feb 17, 2019

By the way support for other scripts might be required as well (see wikidata item).

CharlesNepote added a commit that referenced this issue Mar 13, 2020
@CharlesNepote
Add 公克 for metric grams in chinese, see #1618
328c3b9 
(please test before)
@CharlesNepote CharlesNepote mentioned this issue Mar 13, 2020
Merged
CharlesNepote added a commit that referenced this issue Mar 19, 2020
@CharlesNepote
Merge pull request #3028 from openfoodfacts/CharlesNepote-issue-#1618
2f2bc53 
Add 公克 for metric grams in chinese, see #1618
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon changed the title Support chinese serving size Support Chinese serving size Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
China portions
Projects
🌍 - Internationalization
Status: 🆕 New
🍊 Open Food Facts Server issues
Status: To discuss and validate
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hangy @aleene @teolemon