Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support some SI weights in Chinese #1666

Conversation

hangy
Copy link
Member

@hangy hangy commented Feb 16, 2019

Description:

Added some Chinese SI unit names to g_to_unit, unit_to_g, normalize_serving_size, and normalize_quantity.

Related issues and discussion: #1618

@hangy hangy requested a review from a team February 16, 2019 19:30
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit 58c37f0 into openfoodfacts:master Feb 19, 2019
@hangy hangy deleted the features/1618-chinese-measurements branch February 19, 2019 15:39
@teolemon teolemon added the China label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants