Add 公克 for metric grams in chinese, see #1618 #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(please test before)
|
New units also need to be added to unit_to_g and g_to_unit functions in Food.pm. "(please test before)" --> Can you add unit tests? :) we have tests for other units in t/food.t |
|
You're right! I didn't know there is such unit test (and that's good!). I'll also document the necessity to write tests, and tell the best practice is to write tests before coding. |
|
Unit tests added and passed :-) |
hangy
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(please test before)
Related issues and discussion: #1618