Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list-user): add exclude list in ListUserResponse #179

Conversation

lalalalatt
Copy link

@lalalalatt lalalalatt commented Jul 15, 2024

Description

I am working on openfga/openfga#1692, and I add a excluded field as describe in the mentioned issue.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Copy link

linux-foundation-easycla bot commented Jul 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@willvedd
Copy link
Contributor

@lalalalatt Appreciate your contribution here. We actually previously implemented a very similar approach to the one you've implemented. For example, please see #171. Its a fine approach but doesn't take into account any feedback or use cases from customers. For that reason, I don't see this as being actionable or ready to review yet.

@lalalalatt
Copy link
Author

@lalalalatt Appreciate your contribution here. We actually previously implemented a very similar approach to the one you've implemented. For example, please see #171. Its a fine approach but doesn't take into account any feedback or use cases from customers. For that reason, I don't see this as being actionable or ready to review yet.

Okay, I see. If there are any updates, please inform me. Thanks!

@willvedd
Copy link
Contributor

@lalalalatt As mentioned in the other PR, I appreciate the contribution and will let you know if/when the excluded users is able to be implemented.

@willvedd willvedd closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants