feat[list-users]: add excluded users field in list users response #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `Excluded` field to `listUsersResponse` struct - Implement `GetExcluded` method in `listUsersResponse` - Track the number of excluded users in `ListUsers` function - Populate `excludedUsers` in `ListUsers` function and include in response - Return `Excluded` field in `ListUsers` RPC response
lalalalatt
changed the title
- Add user exclusion for Bob in test expectations - Implement tracking of unique excluded users in ListUsers function - Adjust excluded users handling in ListUsers function - Add strings package import in listusers test - Separate users and excluded users in test expectations and assertions - Include excluded users in the raw response logs for ListUsers
|
@lalalalatt Thanks for your contribution. I'm going to close this out but will make sure you're aware of any new decisions that are made with respect to excluded users. Please keep an eye out for #1692, that's where I intend the conversation will occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As describe in #1692, the excluded user should show explicitly to prevent the confusion on the type-bound public access which doesn't necessarily indicate that all users of that type have access.
This PR required the approval to the openfga/api#179 that modifying protobuf and generated Go file.
Changes
excluded: []stringin the response of List User Request, in order to show the users excluded from PublicWildcard.listUsersAssertions: - request: filters: - user object: document:1 relation: can_view expectation: - user:* + - (excluded)user:bobReferences
Review Checklist
main