CI: prevent uncommitted artifact changes #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks for diffs on the generated Go files; currently we're only checking for diffs on the swagger file.
This is proven to work because of the failed diff-openapi job that is detecting the very exact thing we're trying to prevent.
Inspired by #173 which could have been detected and prevented.
Once that PR is merged, this job will start passing.Update: that PR was merged and thediff-openapijob is now passing 🎉 .References
Inspiration: #173
Proof of concept: https://github.com/openfga/api/actions/runs/9604720835/job/26490812942?pr=174
Review Checklist
main