fix: regenerating types after removing ObjectOrUserset from API
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamzeh
approved these changes
Jun 20, 2024
|
@willvedd can you make sure you are updating the swagger file too? |
|
We should probably hav a CI job that blocks PRs that don't regen the protos and the swagger |
4 tasks
We actually had that for the swagger file but not for the generated types. I opened #174 to address this. Once this PR gets merged in, that PR should begin passing all checks! |
jpadilla
approved these changes
Jun 20, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ObjectOrUsersetwas removed in #171 but types were not regenerated. This PR introduces those chagnes.References
Original PR: #171
Review Checklist
main