Skip to content

fix: add #page-notification to container_editor.html for XBlock error display #38711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anas12091101 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

fix: add #page-notification to container_editor.html for XBlock error display #38711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions cms/djangoapps/contentstore/views/tests/test_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4756,3 +4756,20 @@ def test_xblock_edit_view_contains_resources(self):

self.assertGreater(len(resource_links), 0, f"No CSS resources found in HTML. Found: {resource_links}") # noqa: PT009 # pylint: disable=line-too-long
self.assertGreater(len(script_sources), 0, f"No JS resources found in HTML. Found: {script_sources}") # noqa: PT009 # pylint: disable=line-too-long

def test_xblock_edit_view_contains_page_notification(self):
"""
The page-notification element is required for XBlock runtime error
notifications (e.g. ORA validation errors) to be visible to the user.
"""
url = reverse_usage_url("xblock_edit_handler", self.video.location)
resp = self.client.get(url)
self.assertEqual(resp.status_code, 200) # noqa: PT009

html_content = resp.content.decode(resp.charset)
soup = BeautifulSoup(html_content, "html.parser")
self.assertIsNotNone( # noqa: PT009
soup.find(id="page-notification"),
"container_editor.html must include a #page-notification element "
"so that XBlock runtime error notifications are rendered.",
)
1 change: 1 addition & 0 deletions cms/templates/container_editor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
</head>

<body class="${static.dir_rtl()} <%block name='bodyclass'></%block> lang_${LANGUAGE_CODE} view-container">
<div id="page-notification"></div>
<%static:js group='base_vendor' />
<%static:webpack entry='commons' />

Expand Down
Loading