fix: add #page-notification to container_editor.html for XBlock error display#38711
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
The container_editor.html template was missing a #page-notification element.
This template is used when the Course Authoring MFE opens legacy XBlock editors
(like ORA) in a ModalIframe via /xblock/{id}/action/edit. Without this element,
the NotificationView had no DOM target, causing XBlock runtime error notifications
(e.g. "Validation error: dates out of order") to fail silently on save.
Useful information to include:
changes.
Supporting information
https://github.com/mitodl/hq/issues/11318
Testing instructions
Testing Instructions:
Navigate to a course in Studio (via the Course Authoring MFE) and open a unit containing an ORA (Open Response Assessment) component, or create a new ORA problem
Click the Edit button on the ORA component to open the legacy editor modal.
In the ORA editor, configure step dates out of order — e.g., set a step's start date earlier than the previous step's start date.
Click Save.
Expected (after fix): A red error notification appears at the bottom of the editor modal with a message like "OpenAssessment Save Error: Validation error: This step's start date cannot be earlier than the previous step's start date." The XBlock data is not saved.
Expected (before fix): No error notification is shown. The save fails silently with no feedback to the user.
Verify that saving with valid dates still works correctly — the modal closes and the component refreshes.
Deadline
"None"