fix: remove duplicate markdown_edited save request [Teak] #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae
kdmccormick
changed the title
|
@bradenmacdonald I think Anas is offline, can you review this backport? I haven't tested yet. Would you be willing to include this commit into #2098 , and then I'll make a PR sandbox against that branch and test both at once? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/teak #2127 +/- ##
===============================================
Coverage ? 93.88%
===============================================
Files ? 1148
Lines ? 24036
Branches ? 5083
===============================================
Hits ? 22567
Misses ? 1401
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sure, done. |
bradenmacdonald
added a commit
that referenced
this pull request
Jun 12, 2025
* fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / #2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: #2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]>
ihor-romaniuk
pushed a commit
to raccoongang/frontend-app-authoring
that referenced
this pull request
Jun 19, 2025
* fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (openedx#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]>
ihor-romaniuk
pushed a commit
to raccoongang/frontend-app-authoring
that referenced
this pull request
Jun 20, 2025
* fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (openedx#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary duplicate save request of markdown_edited value to the backend.
Part of: #2099
Backports: 62589ae , from #2112