-
Notifications
You must be signed in to change notification settings - Fork 132
Backport fix: enable markdown editor in libraries #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fix: enable markdown editor in libraries #2098
Conversation
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/teak #2098 +/- ##
===============================================
Coverage ? 93.90%
===============================================
Files ? 1148
Lines ? 24039
Branches ? 5082
===============================================
Hits ? 22573
Misses ? 1398
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@kdmccormick Now that #2112 is merged and will presumably be backported soon, I'd like to merge this backport - would you mind reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I'm clear -- this isn't a direct backport, but is rather a meant to achieve the same functionality as #2068 (comment) minus the refactoring? If so can you make note of that in the commit?
This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor.
Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae
b335195
to
21e4d6b
Compare
@kdmccormick Sure, I added that note to the commit and cherry-picked in the other fix from #2127 |
Great, I will let you know once I confirm these both on the PR sandbox. @farhaanbukhsh , any objections to both this and #2127 being backported to Teak? It's just more bugfixes for the Switch-to-markdown option in the Problem editor. |
@kdmccormick nope, onwards and upwards for more bugfixes. |
I don't see any sandbox here? I asked on Slack about it. I guess we're waiting on that unless someone can test manually. |
Sandbox deployment successful 🚀 |
Tested creating markdown problems on the sandbox in a library and a course and everything is working well :) |
* fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (openedx#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]>
* fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (openedx#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]>
Description
The markdown problem editor wasn't available in libraries, but probably unintentionally.
Supporting information
Don't merge yet - there is a minor bug with this: #2099
Testing instructions
Create a new problem in a library. Switch to markdown editor.
Confirm that if the waffle flag is modified, the markdown option is no longer available.
Other information