feat: add course overrides listings for unit extensions v2 #345
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
holaontiveros
changed the title
holaontiveros
changed the title
mphilbrick211
added
the
mao-onboarding
|
@openedx/axim-engineering would someone be able to look at this? |
edx_when/api.py
Outdated
| override = udate.actual_date | ||
| dates.append((username, full_name, override)) | ||
| if extra_data: | ||
| email = udate.user.email |
There was a problem hiding this comment.
Maybe this is the wrong place to ask this, but why is the user's email needed?
There was a problem hiding this comment.
The information that it's retrieve it's used to fill this view:
you can find them in: https://www.figma.com/design/RnkfsNvyutLkSDXEhEOkEY/Instructor-Experience?node-id=18268-119872 at the "Date extensions" part
I thought that returning the info from the source that already had it made more sense instead of having to expand the data further in later steps
|
@holaontiveros flagging Feanil's comment above! |
Thank you I'm just getting back from vacations, I already answered @feanil |
4 participants
Description:
This adds a function to get UserDates overides by a whole course given that we already had by use rand by block.
It also modifies the by block to optionally return more data required by the v2 endpoints of the instructor dashboard
Figma link for new instructors dashboard
Dependencies: None
Merge deadline: none
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.